Skip to content

Conversation

@hangrao
Copy link
Contributor

@hangrao hangrao commented Oct 27, 2025

Summary

JIRA:KM-1839

Will generate entities-plugins pr package for testing.

@hangrao
Copy link
Contributor Author

hangrao commented Oct 27, 2025

Tested manually:

  1. cd apps/gateway-manager
  2. pnpm install @kong-ui-public/entities-plugins@pr-2594
  3. pnpm --filter "@kong-ui/konnect-ui-gateway-manager" dev

Go to consumer->credentials->Key Auth->Edit , the Key field is masked.

image

@hangrao hangrao marked this pull request as ready for review October 27, 2025 06:58
@hangrao hangrao requested review from a team as code owners October 27, 2025 06:58
Copy link
Member

@sumimakito sumimakito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Note: I tested this in KM, but it didn't work. After some analysis, it turned out that KM fetches the backend schema for credentials and uses the schema there.

In today's backend schema, we're still missing the "encrypted": true (code reference). With that, we can also make the UI treat this field as a password.

Shall we reach out to the Gateway team and see if we need to add this field in the backend?

@hangrao hangrao merged commit 952f7ef into main Oct 27, 2025
9 checks passed
@hangrao hangrao deleted the fix/mask-key-in-keyauth-consumer branch October 27, 2025 08:28
@hangrao
Copy link
Contributor Author

hangrao commented Oct 27, 2025

LGTM.

Note: I tested this in KM, but it didn't work. After some analysis, it turned out that KM fetches the backend schema for credentials and uses the schema there.

In today's backend schema, we're still missing the "encrypted": true (code reference). With that, we can also make the UI treat this field as a password.

Shall we reach out to the Gateway team and see if we need to add this field in the backend?

Will review the KM part separately, this change is a nice to have change.

For KM, we'll update the fields for UI parts firstly, for backend related will consult PM and gateway team to see if they're going to update their part.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants