Fix property docs not being propagated to generated accessors #4283
+118
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbdullinAM
reviewed
Dec 5, 2025
Member
AbdullinAM
left a comment
AbdullinAM
left a comment
There was a problem hiding this comment.
Hi! Thank you for the PR!
Overall the fix looks good. However, when discussing this topic in a separate PR (#4370) we decided that in would be more suitable and consistent to handle this 'inheritance' for property accessors in Analysis API.
We created an issue explaining the change and it was implemented already, we're waiting for the next release of AA to have it available in Dokka.
Author
|
Alright makes sense, should I close this then? |
Member
|
@Seggan Yes, I think we can close this PR. Thank you once again for creating it, and sorry for a (very) late reply |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3369