Skip to content

Conversation

@pbouffard
Copy link
Contributor

This creates a workaround for #334. On Julia 1.10 and later the default is to disable OhMyREPL's matching of string literal delimiters (a.k.a double quotes ") , and this can be manually done on any Julia version with enable_autocomplete_string_literals(false), which is exported as with the existing enable_autocomplete_brackets.

@codecov-commenter
Copy link

codecov-commenter commented May 1, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 56.18%. Comparing base (b0071f5) to head (d172105).
Report is 27 commits behind head on master.

Files with missing lines Patch % Lines
src/BracketInserter.jl 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #346      +/-   ##
==========================================
- Coverage   56.27%   56.18%   -0.09%     
==========================================
  Files          15       15              
  Lines        1123     1123              
==========================================
- Hits          632      631       -1     
- Misses        491      492       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@BoundaryValueProblems
Copy link

I hope this pull request will be processed very soon since this is a good idea. I just want to disable the autocompletion of " mark but want to keep the autocompletion of brackets!

@Yuan-Ru-Lin
Copy link

Just want to comment on the possibility of adding an option to disable autocompletion of single quotes (') as well. I have found myself typing ' for adjoint and having to delete the additional one given by autocompletion. It would be useful when creating a Char like 'a' but this happens less frequently than adjoint.

@axsk
Copy link

axsk commented Jun 26, 2024

I am not sure if this needs to be an option. I would rather have it disabled by default and reduce configuration complexity.

@KristofferC
Copy link
Owner

Imo, the first thing to do is to only add the option (with docs) etc. That is uncontroversial. Then the question of what the default should be can be discussed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants