Add option to use random numbers as the word separator when generating passphrases #2103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmacklin
force-pushed
the
support-random-numbers-as-passphrase-separator
branch
from
69af5a9 to
cc7cfd8
Compare
rmacklin
force-pushed
the
support-random-numbers-as-passphrase-separator
branch
from
cc7cfd8 to
7617c6a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2102
When generating a passphrase, we will now expose a choice between a static word separator and "random numbers" as the word separator.
Screenshots
Note: I don't have experience with Android UI design, and I put the UI together somewhat hastily. So, I'm not married to this specific UI - I just want this ability to exist in KeePassDX in some form. Feel free to change the presentation as you see fit!