SqueezePlay.pm: Possible wrong string compare???

[chincheta0815]

Hej there,

I am trying to get some proper Mute Info into Squeezelite and found something possibly wrong in Slim/Player/SqueezePlay.pm.

Shouldn't the regexp in that line: https://github.com/Logitech/slimserver/blob/a063401fe91bc81889f3ca2524f1ce6ab349879c/Slim/Player/SqueezePlay.pm#L250

... if (abs($fade) > 1 || $client->model !~ /baby|fab4/) { ...

rather be
... if (abs($fade) > 1 || $client->model =~ /baby|fab4/) { ...

Otherwise the comment
# for long fades do standard behavior so that sleep/alarm work
does not make any sense (at least) to me: squeezelite usually has no internal alarm function.

The issue would also explain why I am getting fade on mute and unmute with squeezelite...

[chincheta0815]

I created a pull request: #910

[michaelherger]

You try to revert/modify a change @philippe44 applied three years ago specifically (I would assume) for squeezelite(-esp). See 12100ea.

What is the exact issue you're trying to solve? Fading in/out IMHO is expected behavior.