Skip to content

Conversation

@jrafanie
Copy link
Member

11-13 English was added in: #23583

  • Updated translations based on 11-13 English
  • Fix bugs in translations (see second commit)

The test caught these bugs:
  1) placeholders translations preserve placeholders in strings
     Failure/Error: expect(errors).to be_empty, "The following mismatched placeholders were found:\n\n#{error_message}"

       The following mismatched placeholders were found:

       >> /Users/joerafaniello/Code/manageiq/locale/de/manageiq.po
       %{number} bytes
       % {number} Bytes

       >> /Users/joerafaniello/Code/manageiq/locale/it/manageiq.po
       %{number} bytes
       % {number} byte
     Shared Example Group: :placeholders called from ./spec/i18n/placeholders_spec.rb:2
     # ./spec/shared/i18n/placeholders.rb:65:in `block (2 levels) in <main>'
     # /Users/joerafaniello/.gem/ruby/3.3.9/gems/webmock-3.26.1/lib/webmock/rspec.rb:39:in `block (2 levels) in <main>'
@Fryguy Fryguy merged commit 275f9e9 into ManageIQ:master Nov 19, 2025
9 checks passed
@jrafanie jrafanie deleted the 11-13-translations branch November 19, 2025 13:57
@Fryguy
Copy link
Member

Fryguy commented Nov 19, 2025

Backported to spassky in commit 61e20a7.

commit 61e20a7f66b5fd37586b9b7a5e9dceafa1f83489
Author: Jason Frey <[email protected]>
Date:   Wed Nov 19 08:57:40 2025 -0500

    Merge pull request #23656 from jrafanie/11-13-translations
    
    11-13 translations
    
    (cherry picked from commit 275f9e93bbd89d56eda10f4d115e22a4e7b36bab)

Fryguy added a commit that referenced this pull request Nov 19, 2025
11-13 translations

(cherry picked from commit 275f9e9)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants