Fixed bug where joined lists of string values are joined with extra quotes

Author: MerlinofMines

EasyCommands.Tests/ScriptTests/FunctionalTests/Operations/SimpleJoinTests.cs

@@ -23,7 +23,18 @@ public void JoinKeyedList() {
 
                 test.RunOnce();
 
-                Assert.AreEqual("one->1, two->2, three->3", test.Logger[0]);
+                Assert.AreEqual("1, 2, 3", test.Logger[0]);
+            }
+        }
+
+        [TestMethod]
+        public void JoinListOfSpacedStrings() {
+            using (var test = new ScriptTest(@"print [""string one"", ""string two"", ""string three""] joined "", """)) {
+                test.MockNextBoundedRandoms(10, 6);
+
+                test.RunOnce();
+
+                Assert.AreEqual("string one, string two, string three", test.Logger[0]);
             }
         }
 

EasyCommands/Common/Operations.cs

@@ -136,7 +136,7 @@ public void InitializeOperators() {
             AddBiOperation<string, string>(BiOperand.MOD, (a, b) => a.Replace(b, ""));
             AddBiOperation<string, float>(BiOperand.SUBTRACT, (a, b) => b >= a.Length ? "" : a.Substring(0, (int)(a.Length - b)));
             AddBiOperation<object, string>(BiOperand.CAST, (a, b) => castMap[b](ResolvePrimitive(a)));
-            AddBiOperation<KeyedList, string>(BiOperand.JOIN, (a, b) => string.Join(CastString(ResolvePrimitive(b)), a.keyedValues.Select(v => v.Print())));
+            AddBiOperation<KeyedList, string>(BiOperand.JOIN, (a, b) => string.Join(CastString(ResolvePrimitive(b)), a.keyedValues.Select(v => CastString(v.GetValue()))));
 
             //Vector
             AddUniOperation<Vector3D>(UniOperand.SIGN, a => Vector3D.Sign(a));

docs/EasyCommands/operations.md

@@ -465,7 +465,7 @@ Keywords: ```^, pow, xor```
 * **(Vector, Vector)**: Returns the angle (in degrees) between the two given vectors (get it? ```^```)
 
 ### Join
-Joins a given list by the given string separator by casting each list value to a string and then joining them together using the given separator.
+Joins a given list by the given string separator by casting each list value to a string and then joining them together using the given separator.  When joining values the keys are stripped.  Only the values get joined.
 
 Keywords: ```join, joined```
 
@@ -477,6 +477,17 @@ set myOutput to [1,2,3] joined ", "
 ```
 #Line Separated Values
 set myOutput to [1,2,3] joined "\n"
+print myOutput
+#1
+#2
+#3
+```
+
+```
+#Keys are stripped
+set myOutput to ["one" -> 1, "two" -> 2, "three" -> 3] joined ", "
+print myOutput
+#1, 2, 3
 ```
 
 ### Modulus