feat: make getCryptoApproveTransactionParams synchronous (#6930)

## Explanation

<!--
Thanks for your contribution! Take a moment to answer these questions so
that reviewers have the information they need to properly understand
your changes:

* What is the current state of things and why does it need to change?
* What is the solution your changes offer and how does it work?
* Are there any changes whose purpose might not obvious to those
unfamiliar with the domain?
* If your primary goal was to update one package but you found you had
to update another one along the way, why did you do so?
* If you had to upgrade a dependency, why did you do so?
-->

- Make `getCryptoApproveTransactionParams` synchronous

## References

<!--
Are there any issues that this pull request is tied to?
Are there other links that reviewers should consult to understand these
changes better?
Are there client or consumer pull requests to adopt any breaking
changes?

For example:

* Fixes #12345
* Related to #67890
-->

## Checklist

- [x] I've updated the test suite for new or updated code as appropriate
- [x] I've updated documentation (JSDoc, Markdown, etc.) for new or
updated code as appropriate
- [x] I've communicated my changes to consumers by [updating changelogs
for packages I've
changed](https://github.com/MetaMask/core/tree/main/docs/contributing.md#updating-changelogs),
highlighting breaking changes as necessary
- [x] I've prepared draft pull requests for clients and consumer
packages to resolve any breaking changes

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> Convert `getCryptoApproveTransactionParams` to a synchronous method
and update tests and changelog accordingly.
> 
> - **Subscription Controller**
> - Change `getCryptoApproveTransactionParams` in
`src/SubscriptionController.ts` from `async` to synchronous (`Promise`
-> direct return).
> - **Tests**
> - Update `src/SubscriptionController.test.ts` to call
`getCryptoApproveTransactionParams` without `await`.
> - **Changelog**
> - Add entry under `Unreleased` noting
`getCryptoApproveTransactionParams` is now synchronous in
`packages/subscription-controller/CHANGELOG.md`.
> 
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
013399d. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

Author: tuna1207

packages/subscription-controller/CHANGELOG.md

@@ -9,6 +9,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Changed
 
+- Make `getCryptoApproveTransactionParams` synchronous ([#6930](https://github.com/MetaMask/core/pull/6930))
 - Bump `@metamask/base-controller` from `^8.4.1` to `^8.4.2` ([#6917](https://github.com/MetaMask/core/pull/6917))
 
 ## [2.0.0]

packages/subscription-controller/src/SubscriptionController.test.ts

@@ -962,7 +962,7 @@ describe('SubscriptionController', () => {
           },
         },
         async ({ controller }) => {
-          const result = await controller.getCryptoApproveTransactionParams({
+          const result = controller.getCryptoApproveTransactionParams({
             chainId: '0x1',
             paymentTokenAddress: '0xtoken',
             productType: PRODUCT_TYPES.SHIELD,
@@ -981,14 +981,14 @@ describe('SubscriptionController', () => {
 
     it('throws when pricing not found', async () => {
       await withController(async ({ controller }) => {
-        await expect(
+        expect(() =>
           controller.getCryptoApproveTransactionParams({
             chainId: '0x1',
             paymentTokenAddress: '0xtoken',
             productType: PRODUCT_TYPES.SHIELD,
             interval: RECURRING_INTERVALS.month,
           }),
-        ).rejects.toThrow('Subscription pricing not found');
+        ).toThrow('Subscription pricing not found');
       });
     });
 
@@ -1003,14 +1003,14 @@ describe('SubscriptionController', () => {
           },
         },
         async ({ controller }) => {
-          await expect(
+          expect(() =>
             controller.getCryptoApproveTransactionParams({
               chainId: '0x1',
               paymentTokenAddress: '0xtoken',
               productType: PRODUCT_TYPES.SHIELD,
               interval: RECURRING_INTERVALS.month,
             }),
-          ).rejects.toThrow('Product price not found');
+          ).toThrow('Product price not found');
         },
       );
     });
@@ -1040,14 +1040,14 @@ describe('SubscriptionController', () => {
           },
         },
         async ({ controller }) => {
-          await expect(
+          expect(() =>
             controller.getCryptoApproveTransactionParams({
               chainId: '0x1',
               paymentTokenAddress: '0xtoken',
               productType: PRODUCT_TYPES.SHIELD,
               interval: RECURRING_INTERVALS.month,
             }),
-          ).rejects.toThrow('Price not found');
+          ).toThrow('Price not found');
         },
       );
     });
@@ -1067,14 +1067,14 @@ describe('SubscriptionController', () => {
           },
         },
         async ({ controller }) => {
-          await expect(
+          expect(() =>
             controller.getCryptoApproveTransactionParams({
               chainId: '0x1',
               paymentTokenAddress: '0xtoken',
               productType: PRODUCT_TYPES.SHIELD,
               interval: RECURRING_INTERVALS.month,
             }),
-          ).rejects.toThrow('Chains payment info not found');
+          ).toThrow('Chains payment info not found');
         },
       );
     });
@@ -1101,14 +1101,14 @@ describe('SubscriptionController', () => {
           },
         },
         async ({ controller }) => {
-          await expect(
+          expect(() =>
             controller.getCryptoApproveTransactionParams({
               chainId: '0x1',
               paymentTokenAddress: '0xtoken',
               productType: PRODUCT_TYPES.SHIELD,
               interval: RECURRING_INTERVALS.month,
             }),
-          ).rejects.toThrow('Invalid chain id');
+          ).toThrow('Invalid chain id');
         },
       );
     });
@@ -1121,14 +1121,14 @@ describe('SubscriptionController', () => {
           },
         },
         async ({ controller }) => {
-          await expect(
+          expect(() =>
             controller.getCryptoApproveTransactionParams({
               chainId: '0x1',
               paymentTokenAddress: '0xtoken-invalid',
               productType: PRODUCT_TYPES.SHIELD,
               interval: RECURRING_INTERVALS.month,
             }),
-          ).rejects.toThrow('Invalid token address');
+          ).toThrow('Invalid token address');
         },
       );
     });
@@ -1162,14 +1162,14 @@ describe('SubscriptionController', () => {
           },
         },
         async ({ controller }) => {
-          await expect(
+          expect(() =>
             controller.getCryptoApproveTransactionParams({
               chainId: '0x1',
               paymentTokenAddress: '0xtoken',
               productType: PRODUCT_TYPES.SHIELD,
               interval: RECURRING_INTERVALS.month,
             }),
-          ).rejects.toThrow('Conversion rate not found');
+          ).toThrow('Conversion rate not found');
         },
       );
     });

packages/subscription-controller/src/SubscriptionController.ts

@@ -421,9 +421,9 @@ export class SubscriptionController extends StaticIntervalPollingController()<
    * @param request.interval - The interval
    * @returns The crypto approve transaction params
    */
-  async getCryptoApproveTransactionParams(
+  getCryptoApproveTransactionParams(
     request: GetCryptoApproveTransactionRequest,
-  ): Promise<GetCryptoApproveTransactionResponse> {
+  ): GetCryptoApproveTransactionResponse {
     const { pricing } = this.state;
     if (!pricing) {
       throw new Error('Subscription pricing not found');