Skip to content

Commit b215c82

Browse files
committed
post-merge updates
CONFIG_ASYNC_TCP_TASK_STACK_SIZE => CONFIG_ASYNC_TCP_STACK_SIZE
1 parent 832c0c4 commit b215c82

File tree

3 files changed

+9
-4
lines changed

3 files changed

+9
-4
lines changed

platformio.ini

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -366,6 +366,7 @@ build_flagsV4 = -g
366366
-DCONFIG_LITTLEFS_FOR_IDF_3_2 -DLFS_THREADSAFE
367367
-D CONFIG_ASYNC_TCP_USE_WDT=0
368368
-D CONFIG_ASYNC_TCP_TASK_STACK_SIZE=9472 ;; WLEDMM increase stack by 1.25Kb, as audioreactive needs bigger SETTINGS_STACK_BUF_SIZE
369+
-D CONFIG_ASYNC_TCP_STACK_SIZE=9472 ;; *sigh* newer asyncTCP uses this instead of .._TASK_..
369370
; -D WLEDMM_TWOPATH ;; use I2S1 as the second bus --> slightly faster on some setups
370371
; -D WLEDMM_SLOWPATH ;; don't use I2S for LED bus
371372
; -DARDUINO_USB_CDC_ON_BOOT=0 ;; mandatory for "classic ESP32" when building with arduino-esp32 >=2.0.3
@@ -399,6 +400,7 @@ build_flags = -g
399400
#-DCONFIG_LITTLEFS_FOR_IDF_3_2
400401
-D CONFIG_ASYNC_TCP_USE_WDT=0
401402
-D CONFIG_ASYNC_TCP_TASK_STACK_SIZE=9472 ;; WLEDMM increase stack by 1.25Kb, as audioreactive needs bigger SETTINGS_STACK_BUF_SIZE
403+
-D CONFIG_ASYNC_TCP_STACK_SIZE=9472 ;; *sigh* newer asyncTCP uses this instead of .._TASK_..
402404
-DARDUINO_USB_CDC_ON_BOOT=0 ;; this flag is mandatory for "classic ESP32" when building with arduino-esp32 >=2.0.3
403405
; -D WLEDMM_TWOPATH ;; use I2S1 as the second bus --> slightly faster on some setups
404406
; -D WLEDMM_SLOWPATH ;; don't use I2S for LED bus
@@ -430,6 +432,7 @@ build_flags = -g
430432
-DCONFIG_LITTLEFS_FOR_IDF_3_2 -DLFS_THREADSAFE ;; WLEDMM
431433
-D CONFIG_ASYNC_TCP_USE_WDT=0
432434
-D CONFIG_ASYNC_TCP_TASK_STACK_SIZE=8614 ;; WLEDMM increase stack by 1Kb, as audioreactive needs bigger SETTINGS_STACK_BUF_SIZE
435+
-D CONFIG_ASYNC_TCP_STACK_SIZE=8614 ;; *sigh* newer asyncTCP uses this instead of .._TASK_..
433436
-DARDUINO_USB_MSC_ON_BOOT=0 -DARDUINO_USB_DFU_ON_BOOT=0
434437
-DCO
435438
-DARDUINO_USB_MODE=0 ;; this flag is mandatory for ESP32-S2 !
@@ -454,6 +457,7 @@ build_flags = -g
454457
-DCONFIG_LITTLEFS_FOR_IDF_3_2 -DLFS_THREADSAFE ;; WLEDMM
455458
-D CONFIG_ASYNC_TCP_USE_WDT=0
456459
-D CONFIG_ASYNC_TCP_TASK_STACK_SIZE=9472 ;; WLEDMM increase stack by 1.25Kb, as audioreactive needs bigger SETTINGS_STACK_BUF_SIZE
460+
-D CONFIG_ASYNC_TCP_STACK_SIZE=9472 ;; *sigh* newer asyncTCP uses this instead of .._TASK_..
457461
-DCO
458462
-DARDUINO_USB_MODE=1 ;; this flag is mandatory for ESP32-C3
459463
;; please make sure that the following flags are properly set (to 0 or 1) by your board.json, or included in your custom platformio_override.ini entry:
@@ -479,6 +483,7 @@ build_flags = -g
479483
-DWLEDMM_NO_SERIAL_WAIT ;; WLEDMM don't wait for serial on -S3 (unless WLED_DEBUG is set)
480484
-D CONFIG_ASYNC_TCP_USE_WDT=0
481485
-D CONFIG_ASYNC_TCP_TASK_STACK_SIZE=9472 ;; WLEDMM increase stack by 1.25Kb, as audioreactive needs bigger SETTINGS_STACK_BUF_SIZE
486+
-D CONFIG_ASYNC_TCP_STACK_SIZE=9472 ;; *sigh* newer asyncTCP uses this instead of .._TASK_..
482487
-DARDUINO_USB_MSC_ON_BOOT=0 -DARDUINO_DFU_ON_BOOT=0
483488
-DCO
484489
;; please make sure that the following flags are properly set (to 0 or 1) by your board.json, or included in your custom platformio_override.ini entry:

usermods/audioreactive/audio_reactive.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -111,12 +111,12 @@
111111

112112
// sanity checks
113113
#ifdef ARDUINO_ARCH_ESP32
114-
// we need more space in for oappend() stack buffer -> SETTINGS_STACK_BUF_SIZE and CONFIG_ASYNC_TCP_TASK_STACK_SIZE
114+
// we need more space in for oappend() stack buffer -> SETTINGS_STACK_BUF_SIZE and CONFIG_ASYNC_TCP_STACK_SIZE
115115
#if SETTINGS_STACK_BUF_SIZE < 3904 // 3904 is required for WLEDMM-0.14.0-b28
116116
#warning please increase SETTINGS_STACK_BUF_SIZE >= 3904
117117
#endif
118-
#if (CONFIG_ASYNC_TCP_TASK_STACK_SIZE - SETTINGS_STACK_BUF_SIZE) < 4352 // at least 4096+256 words of free task stack is needed by async_tcp alone
119-
#error remaining async_tcp stack will be too low - please increase CONFIG_ASYNC_TCP_TASK_STACK_SIZE
118+
#if (CONFIG_ASYNC_TCP_STACK_SIZE - SETTINGS_STACK_BUF_SIZE) < 4352 // at least 4096+256 words of free task stack is needed by async_tcp alone
119+
#error remaining async_tcp stack will be too low - please increase CONFIG_ASYNC_TCP_STACK_SIZE
120120
#endif
121121
#endif
122122

wled00/const.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -435,7 +435,7 @@
435435
#if !defined(USERMOD_AUDIOREACTIVE)
436436
#define SETTINGS_STACK_BUF_SIZE 3834 // WLEDMM added 696+32 bytes of margin (was 3096)
437437
#else
438-
#define SETTINGS_STACK_BUF_SIZE 4000 // WLEDMM more buffer for audioreactive UI (add '-D CONFIG_ASYNC_TCP_TASK_STACK_SIZE=9216' to your build_flags)
438+
#define SETTINGS_STACK_BUF_SIZE 4000 // WLEDMM more buffer for audioreactive UI (add '-D CONFIG_ASYNC_TCP_STACK_SIZE=9216' to your build_flags)
439439
#endif
440440
#endif
441441

0 commit comments

Comments
 (0)