Skip to content

Commit 7ac7466

Browse files
committed
Review fixes.
1 parent c5d202d commit 7ac7466

File tree

1 file changed

+24
-7
lines changed

1 file changed

+24
-7
lines changed

spec.html

Lines changed: 24 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -11208,6 +11208,17 @@ <h1>ECMAScript Function Objects</h1>
1120811208
*true* if this is a class field initializer, *false* otherwise.
1120911209
</td>
1121011210
</tr>
11211+
<tr>
11212+
<td>
11213+
[[PrivateBrand]]
11214+
</td>
11215+
<td>
11216+
Object | *undefined*
11217+
</td>
11218+
<td>
11219+
TODO
11220+
</td>
11221+
</tr>
1121111222
</tbody>
1121211223
</table>
1121311224
</emu-table>
@@ -11454,8 +11465,8 @@ <h1>MakeMethod ( _F_, _homeObject_ )</h1>
1145411465
</emu-alg>
1145511466
</emu-clause>
1145611467

11457-
<emu-clause id="sec-define-ordinary-method" aoid="DefineOrdinaryMethod">
11458-
<h1>DefineOrdinaryMethod ( _key_, _homeObject_, _closure_, _enumerable_ )</h1>
11468+
<emu-clause id="sec-definemethodproperty" aoid="DefineMethodProperty">
11469+
<h1>DefineMethodProperty ( _key_, _homeObject_, _closure_, _enumerable_ )</h1>
1145911470
<emu-alg>
1146011471
1. Perform SetFunctionName(_closure_, _key_).
1146111472
1. If _key_ is a Private Name, then
@@ -20520,7 +20531,7 @@ <h1>Runtime Semantics: MethodDefinitionEvaluation</h1>
2052020531
<emu-grammar>MethodDefinition : ClassElementName `(` UniqueFormalParameters `)` `{` FunctionBody `}`</emu-grammar>
2052120532
<emu-alg>
2052220533
1. Let _methodDef_ be ? DefineMethod of |MethodDefinition| with argument _object_.
20523-
1. Perform ? DefineOrdinaryMethod(_methodDef_.[[Key]], _object_, _methodDef_.[[Closure]], _enumerable_).
20534+
1. Perform ? DefineMethodProperty(_methodDef_.[[Key]], _object_, _methodDef_.[[Closure]], _enumerable_).
2052420535
</emu-alg>
2052520536
<emu-grammar>MethodDefinition : `get` ClassElementName `(` `)` `{` FunctionBody `}`</emu-grammar>
2052620537
<emu-alg>
@@ -20614,7 +20625,7 @@ <h1>Runtime Semantics: MethodDefinitionEvaluation</h1>
2061420625
1. Let _sourceText_ be the source text matched by |AsyncMethod|.
2061520626
1. Let _closure_ be ! OrdinaryFunctionCreate(%AsyncFunction.prototype%, _sourceText_, |UniqueFormalParameters|, |AsyncFunctionBody|, ~non-lexical-this~, _scope_, _privateScope_).
2061620627
1. Perform ! MakeMethod(_closure_, _object_).
20617-
1. Perform ? DefineOrdinaryMethod(_propKey_, _object_, _closure_, _enumerable_).
20628+
1. Perform ? DefineMethodProperty(_propKey_, _object_, _closure_, _enumerable_).
2061820629
</emu-alg>
2061920630
</emu-clause>
2062020631
</emu-clause>
@@ -21502,9 +21513,15 @@ <h1>Runtime Semantics: ClassDefinitionEvaluation</h1>
2150221513
1. If PrivateBoundIdentifiers of |ClassBody| contains a Private Name _P_ such that _P_.[[Kind]] is either ~method~ or ~accessor~ and _P_.[[Brand]] is _proto_, then
2150321514
1. Set _F_.[[PrivateBrand]] to _proto_.
2150421515
1. If PrivateBoundIdentifiers of |ClassBody| contains a Private Name _P_ such that _P_.[[Kind]] is either ~method~ or ~accessor~ and _P_.[[Brand]] is _F_, then
21505-
1. Perform ? PrivateBrandAdd(_F_, _F_).
21516+
1. Let _result_ be PrivateBrandAdd(_F_, _F_).
21517+
1. If _result_ is an abrupt completion, then
21518+
1. Set the running execution context's PrivateEnvironment to _outerPrivateEnvironment_.
21519+
1. Return _result_.
2150621520
1. For each element _fieldRecord_ of _staticFields_, do
21507-
1. Perform ? DefineField(_F_, _fieldRecord_).
21521+
1. Let _result_ be DefineField(_F_, _fieldRecord_).
21522+
1. If _result_ is an abrupt completion, then
21523+
1. Set the running execution context's PrivateEnvironment to _outerPrivateEnvironment_.
21524+
1. Return _result_.
2150821525
1. Set the running execution context's PrivateEnvironment to _outerPrivateEnvironment_.
2150921526
1. Return _F_.
2151021527
</emu-alg>
@@ -21568,7 +21585,7 @@ <h1>Runtime Semantics: Evaluation</h1>
2156821585
1. Let _privateName_ be NewPrivateName(_privateIdentifier_).
2156921586
1. Perform ! _privateEnvRec_.InitializeBinding(_privateIdentifier_, _privateName_).
2157021587
1. Else,
21571-
1. Let _privateName_ be ! _privateEnvRec_.GetBindingValue(_privateIdentifier_).
21588+
1. Let _privateName_ be ! _privateEnvRec_.GetBindingValue(_privateIdentifier_, *true*).
2157221589
1. NOTE: The only case where this may occur is in getter/setter pairs; other duplicates are prohibited as a Syntax Error.
2157321590
1. Assert: _privateName_ is a Private Name.
2157421591
1. Assert: _privateName_.[[Description]] is _privateIdentifier_.

0 commit comments

Comments
 (0)