feat: add navigation history change event and enhance webview data handling

Author: iamEvanYT

src/main/browser/tabs/tab/controllers/data.ts

@@ -1,19 +1,37 @@
 import { Tab } from "@/browser/tabs/tab";
 import { TabbedBrowserWindow } from "@/browser/window";
+import { WebContents } from "electron";
 
 export class TabDataController {
   private readonly tab: Tab;
 
+  // from other controllers
   public window: TabbedBrowserWindow | null = null;
   public space: string | null = null;
   public pipActive: boolean = false;
 
+  // from webview (recorded here)
+  public audible: boolean = false;
+  public muted: boolean = false;
+  public url: string = "";
+  public isLoading: boolean = true;
+
+  // recorded here
+  public asleep: boolean = false;
+
   constructor(tab: Tab) {
     this.tab = tab;
 
     tab.on("window-changed", () => this.refreshData());
     tab.on("space-changed", () => this.refreshData());
     tab.on("pip-active-changed", () => this.refreshData());
+    tab.on("nav-history-changed", () => this.emitDataChanged());
+
+    tab.on("webview-detached", () => this.onWebviewDetached());
+  }
+
+  private emitDataChanged() {
+    this.tab.emit("data-changed");
   }
 
   public refreshData() {
@@ -49,11 +67,42 @@ export class TabDataController {
     return changed;
   }
 
+  public setupWebviewData(webContents: WebContents) {
+    // audible
+    webContents.on("audio-state-changed", () => {});
+    webContents.on("media-started-playing", () => {});
+    webContents.on("media-paused", () => {});
+
+    // title
+    webContents.on("page-title-updated", () => {});
+
+    // isLoading
+    webContents.on("did-finish-load", () => {});
+    webContents.on("did-start-loading", () => {});
+    webContents.on("did-stop-loading", () => {});
+
+    // url
+    webContents.on("did-finish-load", () => {});
+    webContents.on("did-start-navigation", () => {});
+    webContents.on("did-redirect-navigation", () => {});
+    webContents.on("did-navigate-in-page", () => {});
+  }
+
+  private onWebviewDetached() {
+    return false;
+  }
+
   public get() {
+    const tab = this.tab;
+    const navHistory = tab.navigation.navHistory;
+    const navHistoryIndex = tab.navigation.navHistoryIndex;
+
     return {
       window: this.window,
       space: this.space,
-      pipActive: this.pipActive
+      pipActive: this.pipActive,
+      navHistory: navHistory,
+      navHistoryIndex: navHistoryIndex
     };
   }
 }

src/main/browser/tabs/tab/controllers/navigation.ts

@@ -31,7 +31,7 @@ export class TabNavigationController {
     return this._navHistoryIndex ?? this.navHistory.length - 1;
   }
 
-  public setupNavigation(webContents: WebContents) {
+  public setupWebviewNavigation(webContents: WebContents) {
     // Restore the navigation history
     webContents.navigationHistory.restore({
       entries: this.navHistory,
@@ -53,6 +53,8 @@ export class TabNavigationController {
     this.navHistory = navHistory;
     this._navHistoryIndex = activeIndex;
 
+    tab.emit("nav-history-changed");
+
     return true;
   }
 
@@ -79,6 +81,7 @@ export class TabNavigationController {
         }
         this._navHistoryIndex = navHistoryIndex + 1;
       }
+      tab.emit("nav-history-changed");
       return true;
     }
 

src/main/browser/tabs/tab/controllers/webview.ts

@@ -70,7 +70,8 @@ export class TabWebviewController {
       tab.emit("focused");
     });
 
-    tab.navigation.setupNavigation(this.webContents);
+    tab.navigation.setupWebviewNavigation(this.webContents);
+    tab.data.setupWebviewData(this.webContents);
 
     tab.emit("webview-attached");
 

src/main/browser/tabs/tab/index.ts

@@ -29,6 +29,7 @@ type TabEvents = {
   "bounds-changed": [PageBounds];
   "visiblity-changed": [boolean];
   "sleep-changed": [];
+  "nav-history-changed": [];
   "data-changed": [];
 
   focused: [];