chore: remove generate-sui-wallet command

Author: wbbradley

crates/walrus-service/src/client/cli/args.rs

@@ -32,7 +32,6 @@ use walrus_sdk::config::UploadMode;
 use walrus_sui::{
     client::{ExpirySelectionPolicy, ReadClient, SuiContractClient},
     types::{StorageNode, move_structs::Authorized},
-    utils::SuiNetwork,
 };
 use walrus_utils::read_blob_from_file;
 
@@ -488,35 +487,6 @@ pub enum CliCommands {
         #[serde(default = "default::staking_amounts_frost")]
         amounts: Vec<u64>,
     },
-    /// Generates a new Sui wallet.
-    GenerateSuiWallet {
-        /// The path where the wallet configuration will be stored.
-        ///
-        /// If not specified, the command will try to create the wallet configuration at the default
-        /// location `$HOME/.sui/sui_config/`. If the directory already exists, an error will be
-        /// returned specifying to use the Sui CLI to manage the existing wallets.
-        #[arg(long)]
-        path: Option<PathBuf>,
-        /// Sui network for which the wallet is generated.
-        ///
-        /// Available options are `devnet`, `testnet`, `mainnet`, and `localnet`.
-        #[arg(long, default_value_t = default::sui_network())]
-        #[serde(default = "default::sui_network")]
-        sui_network: SuiNetwork,
-        /// Whether to attempt to get SUI tokens from the faucet.
-        #[arg(long)]
-        #[serde(default)]
-        use_faucet: bool,
-        /// Timeout for the faucet call.
-        #[arg(
-            long,
-            value_parser = humantime::parse_duration,
-            default_value = "1min",
-            requires = "use_faucet")
-        ]
-        #[serde(default = "default::faucet_timeout")]
-        faucet_timeout: Duration,
-    },
     /// Exchange SUI for WAL through the configured exchange. This command is only available on
     /// Testnet.
     GetWal {
@@ -690,7 +660,6 @@ impl CliCommands {
             CliCommands::ListBlobs { .. } => "list-blobs",
             CliCommands::Delete { .. } => "delete",
             CliCommands::Stake { .. } => "stake",
-            CliCommands::GenerateSuiWallet { .. } => "generate-sui-wallet",
             CliCommands::GetWal { .. } => "get-wal",
             CliCommands::BurnBlobs { .. } => "burn-blobs",
             CliCommands::FundSharedBlob { .. } => "fund-shared-blob",
@@ -1814,8 +1783,6 @@ impl EpochArg {
 pub(crate) mod default {
     use std::{net::SocketAddr, time::Duration};
 
-    use walrus_sui::utils::SuiNetwork;
-
     pub(crate) fn max_body_size_kib() -> usize {
         10_240
     }
@@ -1883,14 +1850,6 @@ pub(crate) mod default {
         500_000_000 // 0.5 SUI
     }
 
-    pub(crate) fn sui_network() -> SuiNetwork {
-        SuiNetwork::Testnet
-    }
-
-    pub(crate) fn faucet_timeout() -> Duration {
-        Duration::from_secs(60)
-    }
-
     pub(crate) fn allowed_headers() -> Vec<String> {
         vec![
             "content-type".to_string(),

crates/walrus-service/src/client/cli/cli_output.rs

@@ -68,7 +68,6 @@ use crate::client::{
         StakeOutput,
         StorageNodeInfo,
         StoreQuiltDryRunOutput,
-        WalletOutput,
     },
 };
 
@@ -862,16 +861,6 @@ impl CliOutput for StakeOutput {
     }
 }
 
-impl CliOutput for WalletOutput {
-    fn print_cli_output(&self) {
-        println!(
-            "{} Generated a new Sui wallet with address {}",
-            success(),
-            self.wallet_address
-        );
-    }
-}
-
 impl CliOutput for ExchangeOutput {
     fn print_cli_output(&self) {
         println!(

crates/walrus-service/src/client/cli/runner.rs

@@ -20,7 +20,6 @@ use itertools::Itertools as _;
 use rand::seq::SliceRandom;
 use reqwest::Url;
 use serde_json;
-use sui_config::{SUI_CLIENT_CONFIG, sui_config_dir};
 use sui_types::base_types::ObjectID;
 use walrus_core::{
     BlobId,
@@ -67,7 +66,6 @@ use walrus_sdk::{
         },
         config::WalletConfig,
         types::move_structs::{Authorized, BlobAttribute, EpochState},
-        utils::SuiNetwork,
     },
     utils::styled_spinner,
 };
@@ -150,11 +148,10 @@ use crate::{
             ShareBlobOutput,
             StakeOutput,
             StoreQuiltDryRunOutput,
-            WalletOutput,
         },
     },
     common::telemetry::TracingSubscriberBuilder,
-    utils::{self, MetricsAndLoggingRuntime, generate_sui_wallet},
+    utils::{self, MetricsAndLoggingRuntime},
 };
 
 fn apply_upload_mode_to_config(
@@ -343,32 +340,6 @@ impl ClientCommandRunner {
                 self.stake_with_node_pools(node_ids, amounts).await
             }
 
-            CliCommands::GenerateSuiWallet {
-                path,
-                sui_network,
-                use_faucet,
-                faucet_timeout,
-            } => {
-                let wallet_path = if let Some(path) = path {
-                    path
-                } else {
-                    // This automatically creates the Sui configuration directory if it doesn't
-                    // exist.
-                    let config_dir = sui_config_dir()?;
-                    anyhow::ensure!(
-                        config_dir.read_dir()?.next().is_none(),
-                        "The Sui configuration directory {} is not empty; please specify a \
-                        different wallet path using `--path` or manage the wallet using the Sui \
-                        CLI.",
-                        config_dir.display()
-                    );
-                    config_dir.join(SUI_CLIENT_CONFIG)
-                };
-
-                self.generate_sui_wallet(&wallet_path, sui_network, use_faucet, faucet_timeout)
-                    .await
-            }
-
             CliCommands::GetWal {
                 exchange_id,
                 amount,
@@ -1726,18 +1697,6 @@ impl ClientCommandRunner {
         StakeOutput { staked_wal }.print_output(self.json)
     }
 
-    pub(crate) async fn generate_sui_wallet(
-        self,
-        path: &Path,
-        sui_network: SuiNetwork,
-        use_faucet: bool,
-        faucet_timeout: Duration,
-    ) -> Result<()> {
-        let wallet_address =
-            generate_sui_wallet(sui_network, path, use_faucet, faucet_timeout).await?;
-        WalletOutput { wallet_address }.print_output(self.json)
-    }
-
     pub(crate) async fn exchange_sui_for_wal(
         self,
         exchange_id: Option<ObjectID>,

crates/walrus-service/src/client/responses.rs

@@ -15,7 +15,7 @@ use chrono::{DateTime, Utc};
 use futures::{StreamExt as _, stream};
 use serde::Serialize;
 use serde_with::{DisplayFromStr, base64::Base64, serde_as};
-use sui_types::base_types::{ObjectID, SuiAddress};
+use sui_types::base_types::ObjectID;
 use walrus_core::{
     BlobId,
     DEFAULT_ENCODING,
@@ -611,14 +611,6 @@ pub struct StakeOutput {
     pub staked_wal: Vec<StakedWal>,
 }
 
-#[derive(Debug, Clone, Serialize)]
-#[serde(rename_all = "camelCase")]
-/// The output of the `walrus generate-sui-wallet` command.
-pub struct WalletOutput {
-    /// The address of the generated wallet.
-    pub wallet_address: SuiAddress,
-}
-
 #[derive(Debug, Clone, Serialize)]
 #[serde(rename_all = "camelCase")]
 /// The output of the `walrus get-wal` command.

docs/book/usage/networks.md

@@ -63,8 +63,7 @@ available.
 Interacting with Walrus requires a valid Sui Testnet wallet with some amount of SUI tokens. The
 normal way to set this up is via the Sui CLI; see the [installation
 instructions](https://docs.sui.io/guides/developer/getting-started/sui-install) in the Sui
-documentation. If you do not want to install the Sui CLI, you can also generate a new Sui wallet for
-Testnet using `walrus generate-sui-wallet --network testnet`.
+documentation.
 
 After installing the Sui CLI, you need to set up a Testnet wallet by running `sui client`, which
 prompts you to set up a new configuration. Make sure to point it to Sui Testnet, you can use the