[PRME-296] Add missing function return types

Author: adamwhitingnhs

app/src/App.tsx

@@ -7,6 +7,7 @@ import { AwsRum, AwsRumConfig } from 'aws-rum-web';
 import { NdrTokenData } from './types/generic/ndrTokenData';
 import { decodeJwtToken } from './helpers/utils/jwtDecoder';
 import PatientAccessAuditProvider from './providers/patientAccessAuditProvider/PatientAccessAuditProvider';
+import { JSX } from 'react';
 
 const cypress =
     import.meta.env.VITE_MONITOR_ACCOUNT_ID === 'not provided yet' &&
@@ -58,7 +59,7 @@ if (import.meta.env.VITE_ENVIRONMENT === 'development' && !cypress) {
     }
 }
 
-function App() {
+const App = (): JSX.Element => {
     return (
         <ConfigProvider>
             <SessionProvider>
@@ -70,5 +71,5 @@ function App() {
             </SessionProvider>
         </ConfigProvider>
     );
-}
+};
 export default App;

app/src/components/blocks/_arf/completeStage/CompleteStage.tsx

@@ -7,7 +7,7 @@ interface Props {
     documents: Array<UploadDocument>;
 }
 
-function CompleteStage({ documents }: Props) {
+const CompleteStage = ({ documents }: Props): React.JSX.Element => {
     const navigate = useNavigate();
 
     return (
@@ -26,6 +26,6 @@ function CompleteStage({ documents }: Props) {
             </Button>
         </>
     );
-}
+};
 
 export default CompleteStage;

app/src/components/blocks/_arf/documentSearchResults/DocumentSearchResults.tsx

@@ -6,14 +6,15 @@ type Props = {
     searchResults: Array<SearchResult>;
 };
 
-const DocumentSearchResults = (props: Props) => {
-    const sortMethod = (a: SearchResult, b: SearchResult) =>
+const DocumentSearchResults = (props: Props): React.JSX.Element => {
+    const sortMethod = (a: SearchResult, b: SearchResult): number =>
         new Date(a.created) < new Date(b.created) ? 1 : -1;
 
     const orderedResults = [...props.searchResults].sort(sortMethod);
     const tableCaption = (
         <h2 className="document-search-table-caption">List of documents available</h2>
     );
+
     return (
         <Table id="available-files-table-title" caption={tableCaption}>
             <Table.Head>

app/src/components/blocks/_arf/documentSearchResultsOptions/DocumentSearchResultsOptions.tsx

@@ -22,7 +22,7 @@ interface DownloadLinkAttributes {
     filename: string;
 }
 
-const DocumentSearchResultsOptions = (props: Props) => {
+const DocumentSearchResultsOptions = (props: Props): React.JSX.Element => {
     const navigate = useNavigate();
     const baseUrl = useBaseAPIUrl();
     const baseHeaders = useBaseAPIHeaders();
@@ -54,7 +54,7 @@ const DocumentSearchResultsOptions = (props: Props) => {
         }
     }, [linkAttributes]);
 
-    const downloadAll = async () => {
+    const downloadAll = async (): Promise<void> => {
         props.updateDownloadState(SUBMISSION_STATE.PENDING);
         try {
             const preSignedUrl = await getPresignedUrlForZip({
@@ -80,7 +80,7 @@ const DocumentSearchResultsOptions = (props: Props) => {
         }
     };
 
-    const deleteAllDocuments = () => {
+    const deleteAllDocuments = (): void => {
         navigate(routeChildren.ARF_DELETE_CONFIRMATION);
     };
 

app/src/components/blocks/_arf/selectStage/SelectStage.tsx

@@ -21,7 +21,11 @@ interface Props {
     startUpload: () => Promise<void>;
 }
 
-function SelectStage({ setDocuments, documents, startUpload }: Readonly<Props>) {
+const SelectStage = ({
+    setDocuments,
+    documents,
+    startUpload,
+}: Readonly<Props>): React.JSX.Element => {
     const arfInputRef = useRef<HTMLInputElement | null>(null);
 
     const hasFileInput = documents.length > 0;
@@ -107,6 +111,6 @@ function SelectStage({ setDocuments, documents, startUpload }: Readonly<Props>)
             </form>
         </>
     );
-}
+};
 
 export default SelectStage;

app/src/components/blocks/_arf/uploadingStage/UploadingStage.tsx

@@ -12,7 +12,7 @@ interface Props {
     documents: Array<UploadDocument>;
 }
 
-function UploadingStage({ documents }: Props) {
+const UploadingStage = ({ documents }: Props): React.JSX.Element => {
     const pageHeader = 'Your documents are uploading';
     useTitle({ pageTitle: 'Uploading documents' });
 
@@ -63,6 +63,6 @@ function UploadingStage({ documents }: Props) {
             </Table>
         </>
     );
-}
+};
 
 export default UploadingStage;

app/src/components/blocks/_delete/deleteResultStage/DeleteResultStage.tsx

@@ -1,4 +1,4 @@
-import React, { Dispatch, MouseEvent, SetStateAction } from 'react';
+import { Dispatch, MouseEvent, SetStateAction } from 'react';
 import { ButtonLink, Card } from 'nhsuk-react-components';
 import { routes } from '../../../../types/generic/routes';
 import { Link, useNavigate } from 'react-router-dom';
@@ -13,20 +13,22 @@ export type Props = {
     setDownloadStage?: Dispatch<SetStateAction<DOWNLOAD_STAGE>>;
 };
 
-function DeleteResultStage({ numberOfFiles, setDownloadStage }: Props) {
+const DeleteResultStage = ({ numberOfFiles, setDownloadStage }: Props): React.JSX.Element => {
     const navigate = useNavigate();
     const role = useRole();
 
-    const handleClick = (e: MouseEvent<HTMLAnchorElement>) => {
+    const handleClick = (e: MouseEvent<HTMLAnchorElement>): void => {
         e.preventDefault();
         if (setDownloadStage) {
             setDownloadStage(DOWNLOAD_STAGE.REFRESH);
         }
         navigate(routes.LLOYD_GEORGE);
     };
+
     const isGP = role === REPOSITORY_ROLE.GP_ADMIN || role === REPOSITORY_ROLE.GP_CLINICAL;
     const pageHeader = 'You have permanently removed the record of:';
     useTitle({ pageTitle: pageHeader });
+
     return (
         <div className="deletion-complete">
             <Card className="deletion-complete_card">
@@ -86,7 +88,7 @@ function DeleteResultStage({ numberOfFiles, setDownloadStage }: Props) {
                         id="start-again-link"
                         data-testid="start-again-link"
                         to=""
-                        onClick={(e) => {
+                        onClick={(e): void => {
                             e.preventDefault();
                             navigate(routes.START);
                         }}
@@ -97,6 +99,6 @@ function DeleteResultStage({ numberOfFiles, setDownloadStage }: Props) {
             </p>
         </div>
     );
-}
+};
 
 export default DeleteResultStage;

app/src/components/blocks/_delete/deleteSubmitStage/DeleteSubmitStage.tsx

@@ -46,7 +46,11 @@ type IndexViewProps = {
     resetDocState: () => void;
 };
 
-const DeleteSubmitStageIndexView = ({ docType, recordType, resetDocState }: IndexViewProps) => {
+const DeleteSubmitStageIndexView = ({
+    docType,
+    recordType,
+    resetDocState,
+}: IndexViewProps): React.JSX.Element => {
     const patientDetails = usePatient();
     const role = useRole();
     const { register, handleSubmit } = useForm();
@@ -62,8 +66,8 @@ const DeleteSubmitStageIndexView = ({ docType, recordType, resetDocState }: Inde
         'Select whether you want to permanently delete these patient files';
     const userIsGP = role === REPOSITORY_ROLE.GP_ADMIN || role === REPOSITORY_ROLE.GP_CLINICAL;
 
-    const handleYesOption = async () => {
-        const onSuccess = () => {
+    const handleYesOption = async (): Promise<void> => {
+        const onSuccess = (): void => {
             resetDocState();
             setDeletionStage(SUBMISSION_STATE.SUCCEEDED);
             if (userIsGP) {
@@ -99,15 +103,15 @@ const DeleteSubmitStageIndexView = ({ docType, recordType, resetDocState }: Inde
         }
     };
 
-    const handleNoOption = () => {
+    const handleNoOption = (): void => {
         if (role === REPOSITORY_ROLE.GP_ADMIN) {
             navigate(routes.LLOYD_GEORGE);
         } else if (role === REPOSITORY_ROLE.PCSE) {
             navigate(routes.ARF_OVERVIEW);
         }
     };
 
-    const submit = async (fieldValues: FieldValues) => {
+    const submit = async (fieldValues: FieldValues): Promise<void> => {
         const allowedRoles = [REPOSITORY_ROLE.GP_ADMIN, REPOSITORY_ROLE.PCSE];
         if (role && allowedRoles.includes(role)) {
             if (fieldValues.deleteDocs === DELETE_DOCUMENTS_OPTION.YES) {
@@ -224,13 +228,13 @@ const DeleteSubmitStageIndexView = ({ docType, recordType, resetDocState }: Inde
     );
 };
 
-function DeleteSubmitStage({
+const DeleteSubmitStage = ({
     docType,
     numberOfFiles,
     setDownloadStage,
     recordType,
     resetDocState,
-}: Props) {
+}: Props): React.JSX.Element => {
     const pageTitle = `You are removing the ${recordType} record of:`;
     useTitle({ pageTitle });
 
@@ -271,5 +275,5 @@ function DeleteSubmitStage({
             <Outlet />
         </>
     );
-}
+};
 export default DeleteSubmitStage;

app/src/components/blocks/_delete/removeRecordStage/RemoveRecordStage.tsx

@@ -33,7 +33,12 @@ export type Props = {
     resetDocState: () => void;
 };
 
-function RemoveRecordStage({ numberOfFiles, recordType, setDownloadStage, resetDocState }: Props) {
+const RemoveRecordStage = ({
+    numberOfFiles,
+    recordType,
+    setDownloadStage,
+    resetDocState,
+}: Props): React.JSX.Element => {
     useTitle({ pageTitle: 'Remove record' });
     const patientDetails = usePatient();
     const [submissionState, setSubmissionState] = useState(SUBMISSION_STATE.PENDING);
@@ -49,12 +54,12 @@ function RemoveRecordStage({ numberOfFiles, recordType, setDownloadStage, resetD
 
     const mounted = useRef(false);
     useEffect(() => {
-        const onSuccess = (result: Array<SearchResult>) => {
+        const onSuccess = (result: Array<SearchResult>): void => {
             setSearchResults(result);
             setSubmissionState(SUBMISSION_STATE.SUCCEEDED);
         };
 
-        const onPageLoad = async () => {
+        const onPageLoad = async (): Promise<void> => {
             try {
                 const results = await getDocumentSearchResults({
                     nhsNumber,
@@ -92,7 +97,7 @@ function RemoveRecordStage({ numberOfFiles, recordType, setDownloadStage, resetD
 
     const hasDocuments = !!searchResults.length && !!patientDetails;
 
-    const PageIndexView = () => (
+    const PageIndexView = (): React.JSX.Element => (
         <>
             <BackButton />
             <h1>Remove this {recordType} record</h1>
@@ -166,7 +171,7 @@ function RemoveRecordStage({ numberOfFiles, recordType, setDownloadStage, resetD
                     {submissionState === SUBMISSION_STATE.SUCCEEDED && (
                         <Button
                             data-testid="remove-btn"
-                            onClick={() => {
+                            onClick={(): void => {
                                 navigate(routeChildren.LLOYD_GEORGE_DELETE_CONFIRMATION);
                             }}
                         >
@@ -217,5 +222,5 @@ function RemoveRecordStage({ numberOfFiles, recordType, setDownloadStage, resetD
             <Outlet></Outlet>
         </>
     );
-}
+};
 export default RemoveRecordStage;

app/src/components/blocks/_documentUpload/documentSelectOrderStage/DocumentSelectOrderStage.tsx

@@ -302,7 +302,9 @@ const DocumentSelectOrderStage = ({
                                         <Table.Cell>
                                             <Link
                                                 to=""
-                                                onClick={() => viewPdfFile(document.file)}
+                                                onClick={(): void => {
+                                                    void viewPdfFile(document.file);
+                                                }}
                                                 aria-label="Preview - opens in a new tab"
                                                 data-testid={`document-preview-${document.id}`}
                                             >