CCM-11537: Template preview tests

Author: ClareJonesBJSS

frontend/src/__tests__/components/forms/ChooseChannelTemplate/server-action.test.ts

@@ -1,8 +1,10 @@
 import { chooseChannelTemplateAction } from '@forms/ChooseChannelTemplate/server-action';
 import {
+  EMAIL_TEMPLATE,
   getMockFormData,
   NHS_APP_TEMPLATE,
   ROUTING_CONFIG,
+  SMS_TEMPLATE,
 } from '@testhelpers/helpers';
 import { updateRoutingConfig } from '@utils/message-plans';
 import { redirect, RedirectType } from 'next/navigation';
@@ -46,29 +48,53 @@ test('submit form - success updates config and redirects to choose templates', a
             cascadeGroups: ['standard'],
             channel: 'NHSAPP',
             channelType: 'primary',
+            defaultTemplateId: NHS_APP_TEMPLATE.id,
+          },
+          {
+            cascadeGroups: ['standard'],
+            channel: 'EMAIL',
+            channelType: 'primary',
             defaultTemplateId: null,
           },
+          {
+            cascadeGroups: ['standard'],
+            channel: 'SMS',
+            channelType: 'primary',
+            defaultTemplateId: SMS_TEMPLATE.id,
+          },
         ],
       },
-      pageHeading: 'Choose an NHS App template',
-      templateList: [NHS_APP_TEMPLATE],
-      cascadeIndex: 0,
+      pageHeading: 'Choose an email template',
+      templateList: [EMAIL_TEMPLATE],
+      cascadeIndex: 1,
     },
     getMockFormData({
-      channelTemplate: NHS_APP_TEMPLATE.id,
+      channelTemplate: EMAIL_TEMPLATE.id,
     })
   );
 
   expect(mockUpdateRoutingConfig).toHaveBeenCalledWith(ROUTING_CONFIG.id, {
-    ...ROUTING_CONFIG,
     cascade: [
       {
         cascadeGroups: ['standard'],
         channel: 'NHSAPP',
         channelType: 'primary',
         defaultTemplateId: NHS_APP_TEMPLATE.id,
       },
+      {
+        cascadeGroups: ['standard'],
+        channel: 'EMAIL',
+        channelType: 'primary',
+        defaultTemplateId: EMAIL_TEMPLATE.id,
+      },
+      {
+        cascadeGroups: ['standard'],
+        channel: 'SMS',
+        channelType: 'primary',
+        defaultTemplateId: SMS_TEMPLATE.id,
+      },
     ],
+    cascadeGroupOverrides: ROUTING_CONFIG.cascadeGroupOverrides,
   });
 
   expect(mockRedirect).toHaveBeenCalledWith(

frontend/src/__tests__/utils/message-plans.test.ts

@@ -392,19 +392,17 @@ describe('Message plans actions', () => {
         },
       });
 
-      const response = await updateRoutingConfig(
-        validRoutingConfigId,
-        baseConfig
-      );
+      await expect(
+        updateRoutingConfig(validRoutingConfigId, baseConfig)
+      ).rejects.toThrow('Failed to update message plan');
 
       expect(routingConfigApiMock.update).toHaveBeenCalledWith(
         'mock-token',
         validRoutingConfigId,
         baseConfig
       );
-      expect(response).toBeUndefined();
       expect(loggerMock.error).toHaveBeenCalledWith(
-        'Failed to get routing configuration',
+        'Failed to update message plan',
         expect.objectContaining({
           errorMeta: expect.objectContaining({ code: 400 }),
         })
@@ -428,7 +426,7 @@ describe('Message plans actions', () => {
       );
       expect(response).toBeUndefined();
       expect(loggerMock.error).toHaveBeenCalledWith(
-        'Invalid routing configuration object',
+        'Invalid message plan object',
         expect.any(Object)
       );
     });

frontend/src/app/message-plans/choose-email-template/[routingConfigId]/preview-template/[templateId]/page.tsx

@@ -2,7 +2,7 @@
 
 import {
   MessagePlanAndTemplatePageProps,
-  validateSubmittedEmailTemplate,
+  validateEmailTemplate,
 } from 'nhs-notify-web-template-management-utils';
 import { getTemplate } from '@utils/form-actions';
 import { redirect, RedirectType } from 'next/navigation';
@@ -26,7 +26,7 @@ const PreviewEmailTemplateFromMessagePlan = async (
 
   const template = await getTemplate(templateId);
 
-  const validatedTemplate = validateSubmittedEmailTemplate(template);
+  const validatedTemplate = validateEmailTemplate(template);
 
   if (!validatedTemplate) {
     return redirect('/invalid-template', RedirectType.replace);

frontend/src/app/message-plans/choose-nhs-app-template/[routingConfigId]/preview-template/[templateId]/page.tsx

@@ -2,7 +2,7 @@
 
 import {
   MessagePlanAndTemplatePageProps,
-  validateSubmittedNHSAppTemplate,
+  validateNHSAppTemplate,
 } from 'nhs-notify-web-template-management-utils';
 import { getTemplate } from '@utils/form-actions';
 import { redirect, RedirectType } from 'next/navigation';
@@ -26,7 +26,7 @@ const PreviewNhsAppTemplateFromMessagePlan = async (
 
   const template = await getTemplate(templateId);
 
-  const validatedTemplate = validateSubmittedNHSAppTemplate(template);
+  const validatedTemplate = validateNHSAppTemplate(template);
 
   if (!validatedTemplate) {
     return redirect('/invalid-template', RedirectType.replace);

frontend/src/app/message-plans/choose-standard-english-letter-template/[routingConfigId]/preview-template/[templateId]/page.tsx

@@ -2,7 +2,7 @@
 
 import {
   MessagePlanAndTemplatePageProps,
-  validateSubmittedLetterTemplate,
+  validateLetterTemplate,
 } from 'nhs-notify-web-template-management-utils';
 import { getTemplate } from '@utils/form-actions';
 import { redirect, RedirectType } from 'next/navigation';
@@ -26,7 +26,7 @@ const PreviewStandardEnglishLetterTemplateFromMessagePlan = async (
 
   const template = await getTemplate(templateId);
 
-  const validatedTemplate = validateSubmittedLetterTemplate(template);
+  const validatedTemplate = validateLetterTemplate(template);
 
   if (!validatedTemplate) {
     return redirect('/invalid-template', RedirectType.replace);

frontend/src/app/message-plans/choose-text-message-template/[routingConfigId]/preview-template/[templateId]/page.tsx

@@ -2,7 +2,7 @@
 
 import {
   MessagePlanAndTemplatePageProps,
-  validateSubmittedSMSTemplate,
+  validateSMSTemplate,
 } from 'nhs-notify-web-template-management-utils';
 import { getTemplate } from '@utils/form-actions';
 import { redirect, RedirectType } from 'next/navigation';
@@ -26,7 +26,7 @@ const PreviewTextMessageTemplateFromMessagePlan = async (
 
   const template = await getTemplate(templateId);
 
-  const validatedTemplate = validateSubmittedSMSTemplate(template);
+  const validatedTemplate = validateSMSTemplate(template);
 
   if (!validatedTemplate) {
     return redirect('/invalid-template', RedirectType.replace);

frontend/src/components/forms/ChooseChannelTemplate/server-action.ts

@@ -31,10 +31,16 @@ export async function chooseChannelTemplateAction(
     };
   }
 
-  messagePlan.cascade[cascadeIndex].defaultTemplateId =
-    parsedForm.data.channelTemplate;
+  const newCascade = messagePlan.cascade.map((item, index) =>
+    index === cascadeIndex
+      ? { ...item, defaultTemplateId: parsedForm.data.channelTemplate }
+      : item
+  );
 
-  await updateRoutingConfig(messagePlan.id, messagePlan);
+  await updateRoutingConfig(messagePlan.id, {
+    cascade: newCascade,
+    cascadeGroupOverrides: messagePlan.cascadeGroupOverrides,
+  });
 
   redirect(
     `/message-plans/choose-templates/${messagePlan.id}`,

frontend/src/utils/message-plans.ts

@@ -133,16 +133,16 @@ export async function updateRoutingConfig(
   );
 
   if (error) {
-    logger.error('Failed to get routing configuration', error);
-    return;
+    logger.error('Failed to update message plan', error);
+    throw new Error('Failed to update message plan');
   }
 
   if (!data) return undefined;
 
   const result = $RoutingConfig.safeParse(data);
 
   if (!result.success) {
-    logger.error('Invalid routing configuration object', result.error);
+    logger.error('Invalid message plan object', result.error);
     return undefined;
   }