Skip to content

Conversation

@ClareJonesBJSS
Copy link
Contributor

@ClareJonesBJSS ClareJonesBJSS commented Nov 3, 2025

Description

  • Adds filter to backend template retrieval, creating shared abstract class for template and routing queries
  • Filter dev highlighted that the TemplateDto zod validation was swallowing the updatedBy and createdBy fields, added them.
  • Adds template selection to message plan journey
  • Adds preview pages nested under template selection screens, with corresponding update to support multi-id urls in component tests

Screenshot_3-11-2025_82252_localhost
Screenshot_3-11-2025_82417_localhost
Screenshot_3-11-2025_82457_localhost
Screenshot_3-11-2025_82543_localhost
Screenshot_12-11-2025_1395_localhost

Context

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@ClareJonesBJSS ClareJonesBJSS requested review from a team as code owners November 3, 2025 08:28
@ClareJonesBJSS ClareJonesBJSS force-pushed the feature/CCM-11537_select-channel-template branch 16 times, most recently from 9083b02 to a490566 Compare November 12, 2025 12:12
@ClareJonesBJSS ClareJonesBJSS force-pushed the feature/CCM-11537_select-channel-template branch from 1cf53d3 to ae89d54 Compare November 13, 2025 12:51
bhansell1
bhansell1 previously approved these changes Nov 13, 2025
alexnuttall
alexnuttall previously approved these changes Nov 13, 2025
@ClareJonesBJSS ClareJonesBJSS dismissed stale reviews from alexnuttall and bhansell1 via 842a39d November 13, 2025 14:13
@ClareJonesBJSS ClareJonesBJSS merged commit 91152c4 into main Nov 17, 2025
44 checks passed
@ClareJonesBJSS ClareJonesBJSS deleted the feature/CCM-11537_select-channel-template branch November 17, 2025 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants