Take PLR into account in the calculation of leaving water temperature of Coil:Heating:Water for cycling operations

[lymereJ]

Pull request overview

• Fixes Energy imbalance in plant loop when changing component Flow Mode #11058
• Recalculate the outlet water temperature by accounting for the PLR during cycling operations

Pull Request Author

• Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
• Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
• Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
• Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
• If any diffs are expected, author must demonstrate they are justified using plots and descriptions
• If changes fix a defect, the fix should be demonstrated in plots and descriptions

Reviewer

• Perform a Code Review on GitHub
• If branch is behind develop, merge develop and build locally to check for side effects of the merge
• If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
• If feature, test running new feature, try creative ways to break it
• CI status: all green or justified
• Check that performance is not impacted (CI Linux results include performance check)
• Run Unit Test(s) locally
• Check any new function arguments for performance impacts
• Verify IDF naming conventions and styles, memos and notes and defaults
• If new idf included, locally check the err file and other outputs

[github-actions]

⚠️ Regressions detected on macos-14 for commit 3e29664

Regression Summary

• ESO Big Diffs: 6
• MTR Big Diffs: 6
• Table Big Diffs: 9
• ESO Small Diffs: 2
• MTR Small Diffs: 1
• Table String Diffs: 8
• EIO: 4
• ERR: 1

• View Results
• Download Regressions

[github-actions]

⚠️ Regressions detected on macos-14 for commit 9d96c52

Regression Summary

• ESO Big Diffs: 4
• MTR Big Diffs: 6
• Table Big Diffs: 9
• ESO Small Diffs: 7
• MTR Small Diffs: 3
• Table String Diffs: 6
• EIO: 3
• Table Small Diffs: 1
• ERR: 1

• View Results
• Download Regressions

[github-actions]

⚠️ Regressions detected on macos-14 for commit ddbb87c

Regression Summary

• ESO Big Diffs: 4
• MTR Big Diffs: 6
• Table Big Diffs: 9
• ESO Small Diffs: 7
• MTR Small Diffs: 3
• Table String Diffs: 6
• EIO: 3
• Table Small Diffs: 1
• ERR: 1

• View Results
• Download Regressions

[github-actions]

⚠️ Regressions detected on macos-14 for commit e4f5d5a

Regression Summary

• Table Big Diffs: 11
• ESO Big Diffs: 3
• MTR Big Diffs: 5
• ESO Small Diffs: 5
• MTR Small Diffs: 2
• Table String Diffs: 6
• EIO: 2

• View Results
• Download Regressions

[github-actions]

⚠️ Regressions detected on macos-14 for commit e4f5d5a

Regression Summary

• Table Big Diffs: 11
• ESO Big Diffs: 3
• MTR Big Diffs: 5
• ESO Small Diffs: 5
• MTR Small Diffs: 2
• Table String Diffs: 6
• EIO: 2

• View Results
• Download Regressions

[Myoldmopar]

(@lymereJ my apologies, I pushed a commit to test something out on a branch that causes diffs. If it's acting funny at all, I'll revert it back out in the morning.)

[github-actions]

⚠️ Regressions detected on macos-14 for commit 46f70d9

Regression Summary

• ESO Big Diffs: 3
• MTR Big Diffs: 5
• Table Big Diffs: 8
• ESO Small Diffs: 5
• MTR Small Diffs: 2
• Table String Diffs: 6
• EIO: 2

• View Results
• Download Regressions

[github-actions]

⚠️ Regressions detected on macos-14 for commit e4f90c9

Regression Summary

• ESO Big Diffs: 3
• MTR Big Diffs: 5
• Table Big Diffs: 8
• ESO Small Diffs: 5
• MTR Small Diffs: 2
• Table String Diffs: 6
• EIO: 2

• View Results
• Download Regressions

[nrel-bot-2]

@lymereJ @Myoldmopar it has been 29 days since this pull request was last updated.

[nrel-bot-2]

@lymereJ @Myoldmopar it has been 40 days since this pull request was last updated.

[nrel-bot-2]

@lymereJ @Myoldmopar it has been 33 days since this pull request was last updated.

[github-actions]

⚠️ Regressions detected on ubuntu-24.04 for commit c3e5ec9

Regression Summary

• ESO Big Diffs: 3
• MTR Big Diffs: 5
• Table Big Diffs: 8
• Table String Diffs: 7
• ESO Small Diffs: 5
• MTR Small Diffs: 2
• EIO: 2

• View Results
• Download Regressions

[github-actions]

⚠️ Regressions detected on macos-14 for commit c3e5ec9

Regression Summary

• ESO Small Diffs: 5
• MTR Small Diffs: 2
• Table Big Diffs: 8
• Table String Diffs: 6
• ESO Big Diffs: 3
• MTR Big Diffs: 5
• EIO: 2

• View Results
• Download Regressions

[mitchute]

@lymereJ Is this ready for a closer look?

[lymereJ]

@mitchute - Short answer, no, It's not complete. I'm not sure if I'll have time to get to it before the upcoming release. If we could keep it open, that would be great.

There's another piece to it that I have not pushed yet (I might create a different issue/PR for it) and I'm not sure that I like the proposed changes even though it addresses the issue.