Skip to content

Update IDD Table:Independent Variable - Fix for IDF editor 'Too many fields for object:Table:IndependentVariable Error' #11297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 31, 2025
Merged

Update IDD Table:Independent Variable - Fix for IDF editor 'Too many fields for object:Table:IndependentVariable Error' #11297

merged 5 commits into from
Oct 31, 2025

Conversation

@mitchute
Copy link
Collaborator

Pull request overview

Description of the purpose of this PR

Pull Request Author

  • Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
  • Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
  • Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
  • Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
  • If any diffs are expected, author must demonstrate they are justified using plots and descriptions
  • If changes fix a defect, the fix should be demonstrated in plots and descriptions
  • If any defect files are updated to a more recent version, upload new versions here or on DevSupport
  • If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
  • If structural output changes, add to output rules file and add OutputChange label
  • If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies
  • If adding/removing any output files (e.g., eplustbl.*)
    • Update ..\scripts\Epl-run.bat
    • Update ..\scripts\RunEPlus.bat
    • Update ..\src\EPLaunch\ MainModule.bas, epl-ui.frm, and epl.vbp (VersionComments)
    • Update ...github\workflows\energyplus.py

Reviewer

  • Perform a Code Review on GitHub
  • If branch is behind develop, merge develop and build locally to check for side effects of the merge
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified
  • Check that performance is not impacted (CI Linux results include performance check)
  • Run Unit Test(s) locally
  • Check any new function arguments for performance impacts
  • Verify IDF naming conventions and styles, memos and notes and defaults
  • If new idf included, locally check the err file and other outputs

@mitchute mitchute self-assigned this Oct 27, 2025
@mitchute mitchute added this to the EnergyPlus 25.2 milestone Oct 27, 2025
@mitchute mitchute added Defect Includes code to repair a defect in EnergyPlus DoNotPublish Includes changes that shouldn't be reported in the changelog labels Oct 27, 2025
@mitchute mitchute requested a review from mjwitte October 27, 2025 15:33
@mitchute mitchute added the IDDChange Code changes impact the IDD file (cannot be merged after IO freeze) label Oct 27, 2025
mjwitte
mjwitte reviewed Oct 28, 2025
View reviewed changes
idd/versions/V25-1-0-Energy+.idd Outdated
\type real
N8,N9,N10,N11,N12,N13,N14,N15,N16,N17,N18,N19,N20;
N8,N9,N10,N11,N12,N13,N14,N15,N16,N17,N18,N19,N20,N21,N22,N23,N24,N25,N26,N27,N28,N29,N30, \note fields as indicated
N31,N32,N33,N34,N35,N36,N37,N38,N39,N40,N41,N42,N43,N44,N45,N46,N47,N48,N49,N50; \note fields as indicated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why change the 24-2 and 25-1 files? Transition should work ok without these change, because they are extensible. And IDF Editor won't be looking at these, either.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, thanks for the clarification. I assumed IDF Editor would need this in the current IDD so that's why I propagated it forward, but I can roll those back.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IDF Editor just reads the Energy+.idd that is in the root of the installed version.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But it won't hurt anything to leave these. I did not run a transition test.

mitchute
mitchute commented Oct 31, 2025
View reviewed changes
Copy link
Collaborator Author

@mitchute mitchute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless I hear other comments, I think this is ready, and should be a non-breaking IDD change to support IDF editor.

idd/Energy+.idd.in
Comment on lines -98585 to +98589
N8,N9,N10,N11,N12,N13,N14,N15,N16,N17,N18,N19,N20;
N8,N9,N10,N11,N12,N13,N14,N15,N16,N17,N18,N19,N20,N21,N22,N23,N24,N25,N26,N27,N28,N29,N30, \note fields as indicated
N31,N32,N33,N34,N35,N36,N37,N38,N39,N40,N41,N42,N43,N44,N45,N46,N47,N48,N49,N50, \note fields as indicated
N51,N52,N53,N54,N55,N56,N57,N58,N59,N60,N61,N62,N63,N64,N65,N66,N67,N68,N69,N70, \note fields as indicated
N71,N72,N73,N74,N75,N76,N77,N78,N79,N80,N81,N82,N83,N84,N85,N86,N87,N88,N89,N90, \note fields as indicated
N91,N92,N93,N94,N95,N96,N97,N98,N99,N100; \note fields as indicated
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went ahead and rolled back the changes to the old IDDs, and extended this a bit further.

testfiles/1ZoneDataCenterCRAC_wApproachTemp_ClassH1.idf
Comment on lines -583 to +584
34.88889, !- Extended Field
50.00000; !- Extended Field
34.88889, !- <none>
50.00000; !- <none>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went a head and ran IDF formatting again with these changes, and this is the result. Cleaning up this can be a follow-up issue later.

testfiles/HVAC3Zone-IntGains-Def.imf
Comment on lines -1 to -8
! Version,
! 8.9; !- Version Identifier
! Version,
! 9.0; !- Version Identifier

! Version,
! 25.2; !- Version Identifier

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleting some of these old version identifiers.

@mitchute
Copy link
Collaborator Author

Everything looks happy. Merging.

@mitchute mitchute merged commit 4b28604 into develop Oct 31, 2025
11 checks passed
@mitchute mitchute deleted the IDFeditorTableIndependentVariableIssue branch October 31, 2025 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mjwitte mjwitte mjwitte left review comments

Assignees

@mitchute mitchute

Labels

Defect Includes code to repair a defect in EnergyPlus DoNotPublish Includes changes that shouldn't be reported in the changelog IDDChange Code changes impact the IDD file (cannot be merged after IO freeze)

Projects

None yet

Milestone

EnergyPlus 25.2

Development

Successfully merging this pull request may close these issues.

6 participants

@mitchute @mjwitte @nrel-bot-2 @nrel-bot-2c @antonszilasi