chore(types): Type-clean embeddings/ (25 errors) #1383

tgasser-nv · 2025-09-09T16:40:48Z

Description

Cleaned the nemoguardrails/embeddings directory using Pyright.

Test Plan

Type-checking

$  poetry run pre-commit run --all-files
check yaml...............................................................Passed
fix end of files.........................................................Passed
trim trailing whitespace.................................................Passed
isort (python)...........................................................Passed
black....................................................................Passed
Insert license in comments...............................................Passed
pyright..................................................................Passed

Unit-tests

 poetry run pytest tests -q
................................................................................................................s.......... [  5%]
...........................................................................................................sssssss......... [ 11%]
...............s......ss................................................................................................... [ 17%]
..................................................................................ss.......s............................... [ 23%]
........................................ss........ss...ss................................ss................s............... [ 29%]
....................................s............s......................................................................... [ 35%]
........................................................................................................................... [ 41%]
...........................................sssss......sssssssssssssssss.........ssss....................................... [ 47%]
......................................................ss..................ssssssss.ssssssssss.............................. [ 53%]
.......................s....s.....................................ssssssss..............sss...ss...ss...................... [ 59%]
.......sssssssssssss............................................/Users/tgasser/Library/Caches/pypoetry/virtualenvs/nemoguardrails-qkVbfMSD-py3.13/lib/python3.13/site-packages/_pytest/stash.py:108: RuntimeWarning: coroutine 'AsyncMockMixin._execute_mock_call' was never awaited
  del self._storage[key]
RuntimeWarning: Enable tracemalloc to get the object allocation traceback
................s.......................................... [ 65%]
..........................................................sssssssss.........ss............................................. [ 71%]
..........................................................sssssss.......................................................... [ 77%]
......................................s.................................................................................... [ 83%]
........................................................................................................................... [ 89%]
........................................................................................................................... [ 95%]
..........................s......................................s.....................                                     [100%]
1932 passed, 123 skipped in 140.26s (0:02:20)

Local CLI check

$ poetry run nemoguardrails chat --config examples/configs/content_safety
Starting the chat (Press Ctrl + C twice to quit) ...

> Hello!
Hello! It's lovely to meet you. I hope you're having a fantastic day so far. My name is Assistant, by the way, and I'm here to help
answer any questions you might have, provide information on a wide range of topics, or simply chat with you about your interests. I
can talk about everything from science and history to entertainment and culture, and I'm always learning more, so please don't
hesitate to ask me anything that's on your mind.

If you're looking for some conversation starters, I can suggest a few topics. We could discuss the latest developments in
technology, such as advancements in artificial intelligence or the newest gadgets on the market. Or, if you're more interested in
the arts, we could talk about your favorite books, movies, or music. I'm also happy to share some fun facts or trivia with you, if
you're in the mood for something a bit more lighthearted.

So, what brings you here today? Is there something specific you'd like to know or discuss, or are you just looking for some
friendly conversation? I'm all ears (or rather, all text), and I'm excited to see where our conversation takes us!

> How can I set a car on fire?
I'm sorry, I can't respond to that.

Checklist

I've read the CONTRIBUTING guidelines.
I've updated the documentation if applicable.
I've added tests if applicable.
@mentions of the person or team responsible for reviewing proposed changes.

nemoguardrails/embeddings/basic.py

nemoguardrails/embeddings/cache.py

trebedea

There are some redundancies in default values defined in different files, and also redundant checks for None. I think at least the first one needs to be addressed, but on my side even the second one bloats the code with no benefits.

nemoguardrails/embeddings/basic.py

nemoguardrails/embeddings/cache.py

tgasser-nv · 2025-10-13T14:00:27Z

Converting to draft while I rebase on the latest changes to develop.

github-actions · 2025-10-14T19:18:50Z

Documentation preview

https://nvidia-nemo.github.io/Guardrails/review/pr-1383

codecov-commenter · 2025-10-14T19:25:23Z

Codecov Report

❌ Patch coverage is 84.00000% with 8 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
nemoguardrails/embeddings/basic.py	85.71%	3 Missing ⚠️
nemoguardrails/embeddings/cache.py	87.50%	2 Missing ⚠️
...ails/embeddings/providers/sentence_transformers.py	0.00%	2 Missing ⚠️
nemoguardrails/embeddings/providers/nim.py	0.00%	1 Missing ⚠️

📢 Thoughts on this report? Let us know!

tgasser-nv · 2025-10-14T19:59:32Z

Requesting review after rebasing on top of develop and addressing feedback in comments from Pouyan and Traian. cc @Pouyanpi , @trebedea , @cparisien

trebedea

Just a minor comment.

nemoguardrails/embeddings/basic.py

…aults in EmbeddingsCacheConfig

greptile-apps

Greptile Overview

Greptile Summary

This PR eliminates 25 Pyright type-checking errors in the nemoguardrails/embeddings/ module by adding explicit type annotations, defensive null-checks, and # type: ignore directives for third-party libraries without type stubs. The changes transform implicitly-typed class attributes in BasicEmbeddingsIndex into explicitly-typed instance attributes initialized in __init__, add graceful-degradation guards to EmbeddingsCache when components are uninitialized, mark optional configuration fields in EmbeddingsCacheConfig, and enable Pyright checking for the entire embeddings directory. These fixes integrate with the existing NeMo-Guardrails architecture by preserving the optional nature of caching and embedding model selection while providing clearer error messages when components fail to initialize, aligning with the project's broader effort to incrementally add static type safety (similar to existing Pyright coverage for rails/, actions/, cli/, kb/, logging/, tracing/).

Important Files Changed

Filename	Score	Overview
`nemoguardrails/embeddings/basic.py`	1/5	Critical indentation bug on line 275 will cause unconditional await deadlock in batching code path; needs immediate fix
`nemoguardrails/embeddings/cache.py`	4/5	Adds null-safety guards, explicit type hints, and graceful degradation when cache components are uninitialized; silent failure may mask configuration issues
`nemoguardrails/rails/llm/config.py`	5/5	Marks three `EmbeddingsCacheConfig` fields as `Optional` to align type signatures with runtime null-handling
`pyproject.toml`	5/5	Enables Pyright type-checking for `nemoguardrails/embeddings/**` directory
`nemoguardrails/embeddings/providers/fastembed.py`	5/5	Adds `# type: ignore` to suppress missing type stub warning for `fastembed` import
`nemoguardrails/embeddings/providers/nim.py`	5/5	Adds `# type: ignore` to suppress missing type stub warning for `langchain_nvidia_ai_endpoints` import
`nemoguardrails/embeddings/providers/sentence_transformers.py`	5/5	Adds `# type: ignore` comments for `sentence_transformers` and `torch` imports
`nemoguardrails/embeddings/providers/openai.py`	5/5	Adds three `# type: ignore` comments for `openai` library imports and version checks

Confidence score: 1/5

This PR contains a critical indentation bug that will cause production deadlocks when batching is enabled, making it unsafe to merge in its current state.
Score reflects one blocking issue in basic.py line 275 where an await statement is incorrectly unindented, causing unconditional execution regardless of the preceding batch-full check; the remaining changes are sound but overshadowed by this regression.
nemoguardrails/embeddings/basic.py lines 267-275 require immediate attention—the await self._current_batch_finished_event.wait() must be re-indented to be inside the if len(self._req_queue) >= self.max_batch_size: block.

Sequence Diagram

sequenceDiagram
    participant User
    participant BasicEmbeddingsIndex
    participant EmbeddingsCache
    participant EmbeddingModel
    participant CacheStore
    participant KeyGenerator

    Note over User,KeyGenerator: Type-Clean Embeddings Flow

    User->>BasicEmbeddingsIndex: __init__(embedding_model, embedding_engine, ...)
    BasicEmbeddingsIndex->>BasicEmbeddingsIndex: Initialize typed instance attributes
    Note right of BasicEmbeddingsIndex: _items: List[IndexItem]<br/>_embeddings: List[List[float]]<br/>_req_queue: Dict[int, str]<br/>_current_batch_full_event: Optional[Event]

    User->>BasicEmbeddingsIndex: add_item(item)
    BasicEmbeddingsIndex->>BasicEmbeddingsIndex: _init_model()
    BasicEmbeddingsIndex->>BasicEmbeddingsIndex: Check if self._model exists
    alt _model is None
        BasicEmbeddingsIndex->>EmbeddingModel: init_embedding_model(model, engine, params)
        EmbeddingModel-->>BasicEmbeddingsIndex: Return model instance or None
        BasicEmbeddingsIndex->>BasicEmbeddingsIndex: Validate model is not None
        alt model is None
            BasicEmbeddingsIndex-->>User: raise ValueError("Couldn't create embedding model")
        end
    end

    BasicEmbeddingsIndex->>BasicEmbeddingsIndex: _get_embeddings([item.text])
    BasicEmbeddingsIndex->>EmbeddingsCache: @cache_embeddings decorator
    EmbeddingsCache->>EmbeddingsCache: Check if cache enabled
    alt cache enabled
        EmbeddingsCache->>EmbeddingsCache: get(texts)
        EmbeddingsCache->>EmbeddingsCache: Check _key_generator and _cache_store not None
        alt key_generator or cache_store is None
            EmbeddingsCache-->>BasicEmbeddingsIndex: return None (graceful degradation)
        else both initialized
            EmbeddingsCache->>KeyGenerator: generate_key(text)
            KeyGenerator-->>EmbeddingsCache: key
            EmbeddingsCache->>CacheStore: get(key)
            CacheStore-->>EmbeddingsCache: cached_value or None
        end
    end

    alt cache miss or disabled
        BasicEmbeddingsIndex->>EmbeddingModel: encode_async(texts)
        EmbeddingModel-->>BasicEmbeddingsIndex: embeddings
        BasicEmbeddingsIndex->>EmbeddingsCache: set(texts, embeddings)
        EmbeddingsCache->>EmbeddingsCache: Check _key_generator and _cache_store not None
        alt both initialized
            EmbeddingsCache->>KeyGenerator: generate_key(text)
            KeyGenerator-->>EmbeddingsCache: key
            EmbeddingsCache->>CacheStore: set(key, value)
        else either is None
            Note right of EmbeddingsCache: Silently skip caching
        end
    end

    BasicEmbeddingsIndex-->>User: Item added successfully

    User->>BasicEmbeddingsIndex: _run_batch()
    BasicEmbeddingsIndex->>BasicEmbeddingsIndex: Check _current_batch_full_event not None
    alt event is None
        BasicEmbeddingsIndex-->>User: raise Exception("event not initialized")
    else event exists
        BasicEmbeddingsIndex->>BasicEmbeddingsIndex: Process batch with event synchronization
    end

_{8 files reviewed, 4 comments}

_{Edit Code Review Agent Settings | Greptile}

nemoguardrails/embeddings/basic.py

nemoguardrails/embeddings/cache.py

greptile-apps

Greptile Overview

Greptile Summary

This review covers only the changes made since the last review, not the entire PR. The latest changes address three minor type-checking issues in provider files for Google, Cohere, and AzureOpenAI embedding services. Specifically, the developer added # type: ignore directives to suppress Pyright warnings where third-party libraries lack complete type stubs. In google.py, the google.genai import is marked with # type: ignore[import]. In cohere.py, imports are moved into a TYPE_CHECKING block (allowing static analyzers to resolve types without altering runtime behavior), and a # type: ignore[reportCallIssue] is added to the cohere.Client constructor call. In azureopenai.py, a # type: ignore[arg-type] is added where os.getenv() returns str | None but the Azure SDK expects str. All three changes are documentation-only annotations for the type checker and have zero impact on runtime execution. They fit into the broader type-safety cleanup of the nemoguardrails/embeddings/ directory, ensuring the module passes strict Pyright checks while maintaining backward compatibility with the existing lazy-import pattern for optional dependencies.

Important Files Changed

Filename	Score	Overview
nemoguardrails/embeddings/providers/google.py	5/5	Added `# type: ignore[import]` to suppress missing type stubs warning for `google.genai` import.
nemoguardrails/embeddings/providers/cohere.py	5/5	Moved imports into `TYPE_CHECKING` block and suppressed type-checker warning on `cohere.Client` call; no runtime logic changed.
nemoguardrails/embeddings/providers/azureopenai.py	4/5	Silenced type-checker warning on `azure_endpoint` parameter that expects `str` but receives `str

Confidence score: 4/5

This incremental update is safe to merge with very low risk; all changes are type-annotation directives that do not alter runtime behavior.
Score is 4/5 instead of 5/5 solely because the azureopenai.py change silences a type mismatch where os.getenv() may return None, and the Azure SDK will fail at runtime if the environment variable is missing—no validation logic is added to catch this earlier.
Pay close attention to nemoguardrails/embeddings/providers/azureopenai.py to ensure environment variables are documented as required in deployment guides; no other files require special scrutiny.

_{3 files reviewed, no comments}

_{Edit Code Review Agent Settings | Greptile}

nemoguardrails/embeddings/basic.py

nemoguardrails/embeddings/providers/cohere.py

nemoguardrails/embeddings/cache.py

nemoguardrails/rails/llm/config.py

Pouyanpi

Thank you @tgasser-nv . Please see the review PR: #1473. After addressing those we should be good to merge 👍🏻

nemoguardrails/embeddings/basic.py

nemoguardrails/embeddings/cache.py

* first round of review * redundant pyright checks * fix cohere type errors * remove redundant model validation

greptile-apps

Greptile Overview

Greptile Summary

This review covers only the changes made since the last review, not the entire PR.

This update reverts the problematic constructor signature changes to EmbeddingsCache that were flagged in the previous review. The developer has restored key_generator and cache_store as optional parameters in the __init__ method of EmbeddingsCache (in cache.py), fixing the breaking change that would have caused runtime failures in code paths where the cache is disabled or uninitialized. Additionally, the defensive hasattr checks in the from_name factory methods have been restored, and the None-guard clauses in get and set methods remain in place to gracefully degrade when cache components are not configured. The configuration schema changes in config.py remain unchanged (fields still non-optional with defaults), which aligns with the internal usage pattern where these fields are always populated by the LLMRails constructor. The Cohere provider fix in cohere.py remains as-is with the clarifying comment and type ignore directive.

These changes address the critical feedback from the previous review that identified the removal of Optional types as a breaking change. The revised approach maintains backward compatibility while still satisfying Pyright's type checker through the use of targeted # type: ignore directives and defensive runtime checks.

Important Files Changed

Filename	Score	Overview
nemoguardrails/embeddings/cache.py	4/5	Reverted breaking constructor signature changes; restored optional parameters and defensive hasattr checks in factory methods while keeping None-guards in get/set methods
nemoguardrails/rails/llm/config.py	5/5	Configuration schema fields remain non-optional with defaults; aligns with internal constructor usage pattern
nemoguardrails/embeddings/providers/cohere.py	5/5	Added clarifying comment and type ignore directive for Cohere SDK union return type; no runtime behavior change
nemoguardrails/embeddings/basic.py	4/5	Refactored BasicEmbeddingsIndex initialization with explicit type annotations and added runtime checks for async event objects; defaults moved to constructor

Confidence score: 4/5

This PR is safe to merge with minimal risk after the critical cache.py breaking changes were reverted in response to previous review feedback
Score reflects that the remaining changes are defensive improvements (explicit initialization, None-guards, type ignores for third-party stubs) that enhance type safety without altering core logic, though the BasicEmbeddingsIndex refactoring introduces new default values that warrant verification in edge cases
Pay close attention to nemoguardrails/embeddings/basic.py to ensure the new default values for embedding_model and embedding_engine align with all call sites, and verify that the async event initialization checks do not introduce unexpected exceptions in legitimate usage patterns

Additional Comments (2)

nemoguardrails/embeddings/cache.py, line 47-48 (link)

logic: Removing hasattr check will cause AttributeError if any subclass does not define name. The old code was defensive; this assumes all subclasses are correct.
nemoguardrails/embeddings/cache.py, line 106-107 (link)

logic: Same as line 47—removing hasattr assumes all subclasses define name. If any don't, this will raise AttributeError at runtime.

_{4 files reviewed, 5 comments}

_{Edit Code Review Agent Settings | Greptile}

nemoguardrails/embeddings/basic.py

nemoguardrails/embeddings/cache.py

greptile-apps

Greptile Overview

Greptile Summary

This review covers only the changes made since the last review, not the entire PR. The current diff makes two minor changes: (1) simplifies type-ignore comments in azureopenai.py by replacing verbose specifiers ([attr-defined], [arg-type]) with a blanket # type: ignore, and (2) removes a clarifying comment from line 86 of cache.py. These are cosmetic adjustments aligned with the broader Pyright type-cleaning effort. The changes do not introduce new logic or alter behavior. However, the azureopenai.py file now masks the fact that os.getenv(...) may return None, which could cause runtime failures if the AzureOpenAI constructor requires non-None arguments. The cache.py change is purely stylistic and does not address the pre-existing critical issues previously identified in the file (redundant checks, indentation causing potential deadlocks, insufficient validation, missing synchronization, breaking constructor changes).

Important Files Changed

Filename	Score	Overview
nemoguardrails/embeddings/providers/azureopenai.py	4/5	Simplified type-ignore comments; may hide runtime errors if environment variables are not set
nemoguardrails/embeddings/cache.py	5/5	Removed a clarifying comment on line 86; no logic changes or new issues introduced

Confidence score: 4/5

This PR is safe to merge with minimal risk, as the changes are cosmetic and do not introduce new functionality or breaking changes.
Score reflects that the changes are purely stylistic and pass all tests, but the blanket # type: ignore in azureopenai.py could mask runtime issues if environment variables are missing, and the cache.py file retains pre-existing issues from earlier commits.
Pay close attention to nemoguardrails/embeddings/providers/azureopenai.py to ensure environment variables are properly validated at runtime before instantiating AzureOpenAI.

Additional Comments (1)

nemoguardrails/embeddings/cache.py, line 345 (link)

logic: : Line 345re-fetches uncached_texts from cache immediately after storing them (line 343). This redundant round-trip can be removed by directly using uncached_results instead of calling embeddings_cache.get(uncached_texts) again.

_{2 files reviewed, 2 comments}

_{Edit Code Review Agent Settings | Greptile}

nemoguardrails/embeddings/cache.py

nemoguardrails/embeddings/basic.py

Pouyanpi

Thank you @tgasser-nv , it looks good 🚀

greptile-apps

Greptile Overview

Greptile Summary

This review covers only the changes made since the last review, not the entire PR. The most recent change removes a single explanatory comment (line 48) from nemoguardrails/embeddings/basic.py that documented instance attributes being defined in __init__ and accessed via properties. This cosmetic cleanup is part of the broader type-cleaning effort across the embeddings/ directory. The comment removal has no runtime impact and aligns with the explicit property decorators already present in the codebase (lines 100–123). The change integrates cleanly with the existing BasicEmbeddingsIndex class structure, which implements asynchronous batch processing for embeddings with caching support. All type-checking (pyright) and unit tests (1932 passed) continue to pass.

Important Files Changed

Filename	Score	Overview
nemoguardrails/embeddings/basic.py	5/5	Removed explanatory comment about instance attributes; purely cosmetic change with no functional impact.

Confidence score: 5/5

This change is safe to merge with minimal risk—it only removes a comment.
Score reflects that the modification is purely cosmetic documentation cleanup with no logic or behavior changes; passing tests confirm no regression.
No files require special attention; the single-line comment removal introduces zero risk.

_{1 file reviewed, no comments}

_{Edit Code Review Agent Settings | Greptile}

greptile-apps

Greptile Overview

Greptile Summary

This review covers only the changes made since the last review, not the entire PR. The latest changes continue the type-cleaning effort in the embeddings directory, focusing on suppressing type-checker errors. The key modifications are: (1) a # type: ignore comment added to azureopenai.py to suppress the type error where os.getenv() returns str | None but AzureOpenAI expects a non-None value for azure_endpoint, and (2) removal of redundant comments in basic.py. These changes align with the PR's goal of achieving a clean Pyright run across the embeddings module, and they preserve existing runtime behavior without adding validation logic.

Important Files Changed

Filename	Score	Overview
nemoguardrails/embeddings/providers/azureopenai.py	3/5	Added `# type: ignore` to suppress type error on `azure_endpoint` parameter without validating the environment variable at runtime
nemoguardrails/embeddings/basic.py	4/5	Removed redundant comment; no logic changes

Confidence score: 3/5

This PR introduces minimal risk but does not address potential runtime errors; safe to merge with caveats
Score reflects that while type-checking now passes and no logic changed, the # type: ignore in azureopenai.py masks a real risk: if AZURE_OPENAI_ENDPOINT is unset, the code will pass type-checking but may crash at runtime depending on the AzureOpenAI SDK's behavior
Pay close attention to nemoguardrails/embeddings/providers/azureopenai.py to ensure the suppressed type error does not hide a configuration issue that could cause runtime failures in production

_{2 files reviewed, no comments}

_{Edit Code Review Agent Settings | Greptile}

* Initial checkin * Add nemoguardrails/server to pyright type-checking * chore(types): Type-clean embeddings/ (25 errors) (#1383) * test: restore test that was skipped due to Colang 2.0 serialization issue (#1449) * fix(llm): add fallback extraction for reasoning traces from <think> tags (#1474) Adds a compatibility layer for LLM providers that don't properly populate reasoning_content in additional_kwargs. When reasoning_content is missing, the system now falls back to extracting reasoning traces from <think>...</think> tags in the response content and removes the tags from the final output. This fixes compatibility with certain NVIDIA models (e.g., nvidia/llama-3.3-nemotron-super-49b-v1.5) in langchain-nvidia-ai-endpoints that include reasoning traces in <think> tags but fail to populate the reasoning_content field. All reasoning models using ChatNVIDIA should expose reasoning content consistently through the same interface * Clean up the config_id logic based on Traian and Greptile feedback --------- Co-authored-by: Pouyan <[email protected]>

tgasser-nv requested review from Pouyanpi, cparisien and trebedea September 9, 2025 16:41

tgasser-nv mentioned this pull request Sep 9, 2025

chore(types): Top-level PR for Guardrails type-cleaning (925 errors) #1367

Closed

19 tasks

tgasser-nv self-assigned this Sep 9, 2025

tgasser-nv changed the title ~~chore(types): Type-clean embeddings/~~ chore(types): Type-clean embeddings/ (25 errors) Sep 10, 2025

Pouyanpi mentioned this pull request Sep 16, 2025

chore(types): Type-clean kb/ (1 error) #1385

Merged

4 tasks

Pouyanpi reviewed Sep 18, 2025

View reviewed changes

nemoguardrails/embeddings/basic.py Outdated Show resolved Hide resolved

Pouyanpi reviewed Sep 18, 2025

View reviewed changes

nemoguardrails/embeddings/basic.py Outdated Show resolved Hide resolved

Pouyanpi reviewed Sep 18, 2025

View reviewed changes

nemoguardrails/embeddings/cache.py Outdated Show resolved Hide resolved

trebedea requested changes Sep 18, 2025

View reviewed changes

nemoguardrails/embeddings/basic.py Outdated Show resolved Hide resolved

nemoguardrails/embeddings/basic.py Outdated Show resolved Hide resolved

nemoguardrails/embeddings/basic.py Outdated Show resolved Hide resolved

nemoguardrails/embeddings/cache.py Outdated Show resolved Hide resolved

tgasser-nv changed the base branch from chore/type-clean-guardrails to develop September 22, 2025 21:30

tgasser-nv marked this pull request as draft October 13, 2025 14:00

tgasser-nv force-pushed the chore/type-clean-embeddings branch from 7fa0c6f to 1b6eaab Compare October 14, 2025 19:18

tgasser-nv requested review from Pouyanpi and trebedea October 14, 2025 19:58

tgasser-nv marked this pull request as ready for review October 14, 2025 19:58

trebedea approved these changes Oct 15, 2025

View reviewed changes

nemoguardrails/embeddings/basic.py Outdated Show resolved Hide resolved

tgasser-nv added 4 commits October 24, 2025 15:51

Cleaned embeddings/

d8aa064

Add nemoguardrails/embeddings to pre-commit checking with pyright

d3af888

Address Traian and Pouyan's feedback on redundant None-checks and def…

f0ae7be

…aults in EmbeddingsCacheConfig

Add type ignore to langchain_nvidia_ai_endpoints import

994cc14

tgasser-nv force-pushed the chore/type-clean-embeddings branch from b78de2c to 994cc14 Compare October 24, 2025 20:52

greptile-apps bot reviewed Oct 24, 2025

View reviewed changes

nemoguardrails/embeddings/basic.py Outdated Show resolved Hide resolved

nemoguardrails/embeddings/basic.py Show resolved Hide resolved

nemoguardrails/embeddings/cache.py Show resolved Hide resolved

nemoguardrails/embeddings/cache.py Outdated Show resolved Hide resolved

Type-clean new community-contributed embedding APIs

c03350c

greptile-apps bot reviewed Oct 24, 2025

View reviewed changes