Skip to content

Conversation

@SangwonSUH
Copy link
Contributor

@SangwonSUH SangwonSUH commented Nov 19, 2025

What does this PR do ?

Don't reinvent the wheel

Refactor FilterbankFeatures.forward

Collection: [asr]

Changelog

  • Refactor FilterbankFeatures masking to use make_seq_mask_like

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Requesting review from ASR members: @titu1994, @redoctopus, @jbalam-nv, or @okuchaiev

Additional Information

  • jit.trace-ing of FilterbankFeatures hardcoded to cuda:0. Utilizing make_seq_mask_like solves this issue.

Replace manual mask creation logic with make_seq_mask_like utility function for cleaner and more consistent masking implementation.

Signed-off-by: SangwonSUH <[email protected]>
@github-actions github-actions bot added the ASR label Nov 19, 2025
@SangwonSUH SangwonSUH marked this pull request as ready for review November 19, 2025 13:33
@SangwonSUH SangwonSUH changed the title Refactor FilterbankFeatures masking to use make_seq_mask_like utility Refactor FilterbankFeatures masking to use make_seq_mask_like utility Nov 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant