This repository was archived by the owner on Jan 21, 2025. It is now read-only.
Revert to default saber if selected saber does not exist #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Firepal
force-pushed
the
saber_save_fix
branch
from
86afe5e to
63e538c
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed while working on a new saber (
PR coming soon enoughNevermind, bad git operation deleted the branch) that saving in a version of the game that contains a new saber THEN opening a version of the game without the new saber causes the game to try to select a saber that doesn't exist, and an out-of-bounds array access exception is thrown.This PR adds code that checks if the selected saber exists, and if it doesn't, reverts to default saber.