Write a ".failed" file next to the golden file instead of in temp

Author: micahhahn

src/Elm/Kernel/Test.js

@@ -20,9 +20,7 @@ function _Test_runThunk(thunk)
 
 const fs = require('node:fs');
 const path = require('node:path');
-const os = require('node:os');
 const process = require('node:process');
-const crypto = require('node:crypto');
 
 function _Test_readFile(filePath)
 {
@@ -69,6 +67,16 @@ function WriteFile(root, filePath, contents)
         return __Result_Err(__File_PathEscapesDirectory);
     }
 
+    // Remove failed file if it exists
+    var failedPath = null; 
+    if (!fullPath.endsWith(".failed.html") && fullPath.endsWith(".html")) 
+        failedPath = fullPath.slice(0, -5) + ".failed.html";
+    else if (!fullPath.endsWith(".failed"))
+        failedPath = fullPath + ".failed";
+
+    if (failedPath)
+        fs.unlinkSync(failedPath);
+    
     const fullDir = path.dirname(fullPath);
 
     // Note that this does not throw an error if the directory exists
@@ -89,18 +97,6 @@ var _Test_writeFile = F2(function(filePath, contents)
     return WriteFile(path.resolve("tests"), filePath, contents);
 })
 
-var tempDir = null;
-var _Test_writeTempFile = F2(function(filePath, contents)
-{
-    if (tempDir === null)
-    {
-        tempDir = os.tmpdir() + "/" + crypto.randomUUID();
-        fs.mkdirSync(tempDir);
-    }
-
-    return WriteFile(tempDir, filePath, contents);
-})
-
 var overwriteGoldenFiles = null;
 function _Test_overwriteGoldenFiles(unused)
 {

src/Expect.elm

@@ -635,7 +635,16 @@ equalToFile filePath actual =
                     pass
 
                 else
-                    case File.writeTempFile filePath actual of
+                    let
+                        failedFilePath =
+                            -- Be careful to make the failed final extension .html so that browsers can render it
+                            if String.endsWith ".html" filePath then
+                                String.dropRight (String.length ".html") filePath ++ ".failed.html"
+
+                            else
+                                filePath ++ ".failed"
+                    in
+                    case File.writeFile failedFilePath actual of
                         Ok newAbsolutePath ->
                             let
                                 message =

src/File.elm

@@ -1,4 +1,4 @@
-module File exposing (AbsolutePath, FileError(..), RelativePath, overwriteGoldenFiles, readFile, writeFile, writeTempFile)
+module File exposing (AbsolutePath, FileError(..), RelativePath, overwriteGoldenFiles, readFile, writeFile)
 
 import Elm.Kernel.Test
 
@@ -35,16 +35,6 @@ writeFile =
     Elm.Kernel.Test.writeFile
 
 
-{-| Write the contents of the second argument to the file path in the first argument relative to a temp directory
-
-Returns the absolute file path if successful.
-
--}
-writeTempFile : RelativePath -> String -> Result FileError AbsolutePath
-writeTempFile =
-    Elm.Kernel.Test.writeTempFile
-
-
 {-| Checks the OVERWRITE\_GOLDEN\_FILES environment variable
 -}
 overwriteGoldenFiles : () -> Bool