Add % to "Loading..." indicator #5348
Open
+20
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat:ui-next:icons: add new SPShare and SPDownload icons
This reverts commit cb357f1.
✅ Deploy Preview for ohif-dev canceled.
|
rinslow
force-pushed
the
feature/add-percentage-to-loading-indicator
branch
from
4acbab5 to
3097e8b
Compare
sedghi
requested changes
Aug 25, 2025
Member
sedghi
left a comment
sedghi
left a comment
There was a problem hiding this comment.
I think this should go to customization of this component, i'm not confident every user wants this. See other components and how we use customization Module for it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Added % to loading, so the user can maintain their expectation
Changes & Results
Testing
Checklist
PR
semantic-release format and guidelines.
Code
etc.)
Public Documentation Updates
additions or removals.
Tested Environment