Skip to content

feat: Add commands to load segs and srs for the active viewport #5381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
igoroctaviano wants to merge 16 commits into
base: master
Choose a base branch
from
Open

feat: Add commands to load segs and srs for the active viewport #5381

igoroctaviano wants to merge 16 commits into from
+125 −0

Conversation

@igoroctaviano
Copy link
Contributor

@igoroctaviano igoroctaviano commented Sep 3, 2025 •
edited
Loading

Context

Changes & Results

Testing

Checklist

PR

  • [] My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

  • [] My code has been well-documented (function documentation, inline comments,
    etc.)

Public Documentation Updates

  • [] The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • [] OS:
  • [] Node version:
  • [] Browser:

@netlify
Copy link

netlify bot commented Sep 3, 2025 •
edited
Loading

✅ Deploy Preview for ohif-dev canceled.

Name Link
🔨 Latest commit 801726f
🔍 Latest deploy log https://app.netlify.com/projects/ohif-dev/deploys/692d713ae80ead00085497b8

@cypress
Copy link

cypress bot commented Sep 3, 2025 •
edited
Loading

Viewers    Run #5781

Run Properties:  status check passed Passed #5781  •  git commit 801726ff15: Simplify load commands
Project Viewers
Branch Review feat/load-derived-display-sets
Run status status check passed Passed #5781
Run duration 02m 25s
Commit git commit 801726ff15: Simplify load commands
Committer Igor Octaviano
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 37
View all changes introduced in this branch ↗︎

sedghi
sedghi reviewed Sep 10, 2025
View reviewed changes
sedghi
sedghi reviewed Sep 10, 2025
View reviewed changes
sedghi
sedghi reviewed Sep 10, 2025
View reviewed changes
sedghi
sedghi reviewed Sep 10, 2025
View reviewed changes
Copy link
Member

@sedghi sedghi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see my comments thanks

jbocce
jbocce reviewed Oct 22, 2025
View reviewed changes
extensions/cornerstone/src/commandsModule.ts Outdated
const primaryDisplaySetUID = displaySetInstanceUIDs[0];
const derivedDisplaySets = _getDerivedSegmentations(primaryDisplaySetUID);
if (!derivedDisplaySets.length) {
return;
Copy link
Collaborator

@jbocce jbocce Oct 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we do a console.warn here too?

jbocce
jbocce approved these changes Oct 22, 2025
View reviewed changes
Copy link
Collaborator

@jbocce jbocce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment

@fedorov fedorov mentioned this pull request Oct 23, 2025
Closed
@fedorov
Copy link
Member

fedorov commented Nov 10, 2025

Can someone clarify what needs to be happen to merge this? @igoroctaviano

@igoroctaviano igoroctaviano changed the title feat: Add command to load derived display sets feat: Add command to load derived display sets [on hold] Nov 20, 2025
@igoroctaviano igoroctaviano changed the title feat: Add command to load derived display sets [on hold] feat: Add command to load derived display sets Nov 20, 2025
@igoroctaviano igoroctaviano changed the title feat: Add command to load derived display sets [on hold] feat: Add command to load derived display sets Nov 20, 2025
@igoroctaviano igoroctaviano changed the title [on hold] feat: Add command to load derived display sets feat: Add command to load derived display sets Nov 26, 2025
@igoroctaviano igoroctaviano changed the title feat: Add command to load derived display sets feat: Add commands to load segs and srs for active viewport Nov 26, 2025
@igoroctaviano igoroctaviano changed the title feat: Add commands to load segs and srs for active viewport feat: Add commands to load segs and srs for the active viewport Nov 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sedghi sedghi sedghi left review comments

@jbocce jbocce jbocce approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@igoroctaviano @fedorov @sedghi @jbocce