Skip to content

Conversation

@l1gi
Copy link

@l1gi l1gi commented Dec 2, 2025

Make sure these boxes are checked accordingly before submitting your Pull Request -- thank you.

Contribution style:

Our Contribution agreements:

Changes (if applicable):

Link to ticket: https://redmine.openinfosecfoundation.org/issues/7005

Describe changes:

@l1gi l1gi requested a review from victorjulien as a code owner December 2, 2025 13:35
@github-actions
Copy link

github-actions bot commented Dec 2, 2025

NOTE: This PR may contain new authors.

@codecov
Copy link

codecov bot commented Dec 2, 2025

Codecov Report

❌ Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 84.15%. Comparing base (15b1bf4) to head (2ae652b).
⚠️ Report is 46 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main   #14401    +/-   ##
========================================
  Coverage   84.15%   84.15%            
========================================
  Files        1014     1014            
  Lines      261991   262461   +470     
========================================
+ Hits       220470   220875   +405     
- Misses      41521    41586    +65     
Flag Coverage Δ
fuzzcorpus 63.19% <30.00%> (-0.06%) ⬇️
livemode 18.76% <60.00%> (+0.05%) ⬆️
pcap 44.63% <10.00%> (+<0.01%) ⬆️
suricata-verify 64.93% <20.00%> (+0.01%) ⬆️
unittests 59.23% <40.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@victorjulien victorjulien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good overall.

Requests on the git side:
Ticket reference in the git commit.

Suggestion for the commit subject "os: support Solaris and Sparc"

{ "local7", LOG_LOCAL7 },
{ NULL, -1 }
};
SCEnumCharMap sc_syslog_facility_map[] = { { "auth", LOG_AUTH }, { "authpriv", LOG_AUTHPRIV },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would like to keep this manually formatted, so it would need to be wrapped in clang-format exclusion comments

src/suricata.c Outdated

void SuricataPreInit(const char *progname)
{
/*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would like to see this be a bit more compact, like in a helper func that is just called from here

@l1gi
Copy link
Author

l1gi commented Dec 2, 2025 via email

@victorjulien
Copy link
Member

Before a code block add

// clang-format off

then after it add

// clang-format on

@github-actions
Copy link

github-actions bot commented Dec 3, 2025

NOTE: This PR may contain new authors.

@l1gi l1gi requested a review from victorjulien December 3, 2025 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants