Skip to content

Conversation

@catenacyber
Copy link
Contributor

Link to ticket: https://redmine.openinfosecfoundation.org/issues/
https://redmine.openinfosecfoundation.org/issues/6591

Describe changes:

  • smtp/ftp: refine protocol detection (with probing parser) on QUIT pattern

SV_BRANCH=OISF/suricata-verify#2788

#14399 with new logic preferring QUIT as SMTP unless it is on port 21 (thus FTP)

with probing parser, failinf when it is on port 21 as FTP QUIT

Ticket: 6591
@codecov
Copy link

codecov bot commented Dec 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.16%. Comparing base (3d80c7f) to head (26313fb).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14411      +/-   ##
==========================================
+ Coverage   84.15%   84.16%   +0.01%     
==========================================
  Files        1014     1014              
  Lines      262460   262472      +12     
==========================================
+ Hits       220869   220914      +45     
+ Misses      41591    41558      -33     
Flag Coverage Δ
fuzzcorpus 63.19% <87.50%> (+<0.01%) ⬆️
livemode 18.73% <50.00%> (-0.01%) ⬇️
pcap 44.64% <87.50%> (+0.05%) ⬆️
suricata-verify 64.94% <87.50%> (+0.01%) ⬆️
unittests 59.24% <50.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@suricata-qa
Copy link

WARNING:

field baseline test %
SURI_TLPR1_stats_chk
.uptime 645 623 96.59%
TREX_GENERIC_stats_chk
.decoder.unknown_ethertype 3 4 133.33%
.decoder.event.ethernet.unknown_ethertype 3 4 133.33%

Pipeline = 28587

@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline = 28591

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants