why privileged: true

[trondhindenes]

I'm noticing that the statefulset runs with privileged: true without explaining the reasoning for it, or allowing users to set it to false. I would expect that to be documented if it's a hard requirement for Octopus to work

[MJRichardson]

@trondhindenes priviledged: true is to allow docker-in-docker, for running execution containers on the built-in worker.

It can be disabled by setting enabledDockerInDocker to false, e.g.

octopus:
  enableDockerInDocker: false

Perhaps this should be false by default?

We're working on some changes to make it much easier to run Octopus tasks on a k8s cluster. Once these are done, I think we may disable the built-in worker for self-hosted k8s installations.

There is a comment in the values file. Do you think there is a better place to document this?