Tc fix working width #618
Open
Tc fix working width #618
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also adds extra measurement commands logging and clarifies some documentation
According to: https://www.isobus.net/isobus/attachments/345/ISO11783-11-DDI-290-SetpointWorkState-v1.pdf Each Section Device Element shall at least provide one type of Working Width. If more than one type of Working Width is provided, then the Section Controller shall be capable to use the different Working Width types with the following priority: 1. Actual Working Width (DDI 67) 2. Maximum Working Width (DDI 70) 3. Default Working Width (DDI 68)
GwnDaan
reviewed
Oct 28, 2025
Comment on lines
+239
to
+246
| if (!retVal.width_mm.isValuePresent) | ||
| { | ||
| set_value_from_property(retVal.width_mm, property, DataDescriptionIndex::MaximumWorkingWidth); | ||
| } | ||
| if (!retVal.width_mm.isValuePresent) | ||
| { | ||
| set_value_from_property(retVal.width_mm, property, DataDescriptionIndex::DefaultWorkingWidth); | ||
| } |
There was a problem hiding this comment.
The problem with this implementation is that it's dependent on the order. Example: when the DefaultWorkingWidth comes first in the iteration, that value is chosen
My suggestion: we save all 3 properties in the section variable, and then we have a member function of the Section class that chooses the correct one based on the priority given by the standard
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the Müller Elektronik sprayer working widths weren't correct.
Now it has fallbacks according to: https://www.isobus.net/isobus/attachments/345/ISO11783-11-DDI-290-SetpointWorkState-v1.pdf
Each Section Device Element shall at least provide one type of Working Width. If
more than one type of Working Width is provided, then the Section Controller shall be
capable to use the different Working Width types with the following priority: