Upgrade phpstan

Upgrade phpstan, and rulesets.
Use the phpstan extension loader, to ensure added rulesets are loaded automatically.

Fix the typehint of secondfactor.id to varchar, as it is not an int in the db.

Also fix `doctrine.finalConstructor`.

Author: johanib

ci/qa/phpstan.neon

@@ -1,13 +1,6 @@
 includes:
     - ./phpstan-baseline.php
-    - ../../vendor/phpstan/phpstan-symfony/extension.neon
-    - ../../vendor/phpstan/phpstan-deprecation-rules/rules.neon
-rules:
-    # Put here your cutom rules for this repository
-#    - Surfnet\NoDebugFunctionRule
-#    - Surfnet\InvokableControllerRule
-#    - Surfnet\UntypedIdParamRule
-#    - Surfnet\NoNullOrArrayReturnRule
+
 parameters:
     checkUninitializedProperties: true
     level: 1

composer.json

@@ -67,17 +67,19 @@
         "mockery/mockery": "^1.6.12",
         "overtrue/phplint": ">=9.6.2",
         "phpmd/phpmd": "^2.15",
-        "phpstan/phpstan-deprecation-rules": "^1.2.1",
-        "phpstan/phpstan-doctrine": "^1.5.7",
-        "phpstan/phpstan-mockery": "^1.1.3",
-        "phpstan/phpstan-phpunit": "^1.4.2",
-        "phpstan/phpstan-symfony": "^1.4.16",
+        "phpstan/extension-installer": "^1.4",
+        "phpstan/phpstan": "^2.1.31",
+        "phpstan/phpstan-deprecation-rules": "^2.0.3",
+        "phpstan/phpstan-doctrine": "^2.0.10",
+        "phpstan/phpstan-mockery": "^2.0",
+        "phpstan/phpstan-phpunit": "^2.0.7",
+        "phpstan/phpstan-symfony": "^2.0.8",
         "phpunit/phpunit": "^9.6.29",
         "ramsey/uuid": "^4.9.1",
-        "rector/rector": "^1.2.10",
+        "rector/rector": "^2.2.7",
         "sebastian/exporter": "^4.0.8",
         "sebastian/phpcpd": "^6.0.3",
-        "slevomat/coding-standard": "^8.22.1",
+        "slevomat/coding-standard": "^8.22",
         "squizlabs/php_codesniffer": "^3.13.4",
         "symfony/browser-kit": "6.4.*",
         "symfony/phpunit-bridge": "^7.3.4",
@@ -128,10 +130,11 @@
     },
     "config": {
         "allow-plugins": {
-            "symfony/flex": true,
-            "symfony/runtime": true,
             "dealerdirect/phpcodesniffer-composer-installer": true,
-            "endroid/installer": true
+            "endroid/installer": true,
+            "phpstan/extension-installer": true,
+            "symfony/flex": true,
+            "symfony/runtime": true
         },
         "optimize-autoloader": true,
         "sort-packages": true,
@@ -173,7 +176,13 @@
             {
                 "file": "config/openconext/global_view_parameters.yaml"
             }
-        ]
+        ],
+        "phpstan/extension-installer": {
+          "ignore": [
+            "surfnet/stepup-bundle",
+            "surfnet/stepup-saml-bundle"
+          ]
+        }
     },
     "type": "project"
 }