Update engines.py for optical properties in ImageVolumes #780
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modified engines.py so optical properties can be applied to voxelized volumes. It loops on all materials created in the simulations and set the optical properties only if the material is in "voxel_materials"
Modified engines.py so optical photons can be transported in voxelized volumes (ImageVolumes). Before that, optical properties were only applied to the default material and not those defined in "voxel_materials", preventing the transport of optical photons in ImageVolumes.
test, adding the default material
Contributor
|
Hello @massiabbas, With David we modified a little bit your PR:
Last thing: could you improve the test please? For the moment, it's just a simulation but we prefer to have a real test with a checking at the end of the simulation. Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified engines.py so optical photons can be transported in voxelized volumes (ImageVolumes). Before that, optical properties were only applied to the default material and not those defined in "voxel_materials", preventing the transport of optical photons in ImageVolumes.