Upgrade to OpenADR 3.1 #313
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In OpenADR 3.1 target filters are no longer typed. The set of target labels for a stored entity is represented as a list of strings. And for filtering you now use just a bunch of targets= query parameters. Signed-off-by: Björn Baron <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: Björn Baron <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Björn Baron <[email protected]>
Signed-off-by: Maximilian Pohl <[email protected]>
Signed-off-by: Maximilian Pohl <[email protected]>
Signed-off-by: Maximilian Pohl <[email protected]>
Signed-off-by: Maximilian Pohl <[email protected]>
Make targets non null
Signed-off-by: Björn Baron <[email protected]>
Signed-off-by: Björn Baron <[email protected]>
Signed-off-by: Björn Baron <[email protected]>
The test cases that are still failing are related to the new "object privacy" introduced by OpenADR 3.1 and will be corrected in a future commit. Signed-off-by: Maximilian Pohl <[email protected]>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #313 +/- ##
==========================================
+ Coverage 80.72% 81.04% +0.32%
==========================================
Files 42 41 -1
Lines 4824 4690 -134
==========================================
- Hits 3894 3801 -93
+ Misses 930 889 -41 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
OpenADR 3.1 data model
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.