Silent CTD in heavy combat

[DaloLorn]

This one's probably as old as the game itself; I think I've seen it as far back as pre-WotH, if not Early Access. But we've never had a clear and reliable repro case until DaloLorn/Rising-Stars#96, and in hindsight, I don't remember if it was ever reported to Blind Mind before its dissolution.

When simulating a sufficiently intensive battle, the game has a habit of dying promptly and without notification. Nothing is written to logs, no minidump is created; it simply dies. I've encountered it sporadically, usually in the design sandbox. However, using the savefile provided in the linked issue (attached to this issue for ease of access), it appears to be reliably reproducible within maybe a few minutes of play.

1. Install Rising Stars from the CombatCrashRepro branch, specifically created for archive purposes to maintain compatibility with the attached save.
2. Install the Goodfoot Race Portrait mod from the Steam Workshop.
3. Download, extract, and load the attached save.
4. You should see a Remnant Guardian orbiting a battleworld in deep space, and several size-350 Heavy Carriers to the southeast. Order all of the Heavy Carriers to attack the Guardian. No further action is required: During the battle that ensues, the game will suddenly exit to desktop.

CombatCrashRepro.zip

[DaloLorn]

Looks like the renderer might be falling apart on trying to draw a battle this big. On Skeleton's prompting, I jumped the carriers on top of the Guardian and immediately switched to one of the AI empires to keep the whole affair out of view. (Notably, a previous attempt at culling it out by parking my camera over a whole other galaxy failed; neither camera distance, nor zoom level, nor viewport targeting seem to have any impact.)

Without vision of the battle, the game no longer crashes.

[DaloLorn]

... Never mind, looks like all my negatives so far have been lucky accidents. Just crashed on the alt-empire trick.

[DaloLorn]

Attaching the Goodfoot mod for those unable to fetch it from Steam:

618529995.zip