Skip to content

Conversation

@ncdiehl11
Copy link
Collaborator

This PR adds logic for skipping eager tip dropping if the step returns tips to its tiprack. It also adds eager tip dropping if the pipette is used in the future, but its nozzle configuration differs from its previous use.

Overview

Describe your PR at a high level. State acceptance criteria and how this PR fits into other work. Link issues, PRs, and other relevant resources.

Test Plan and Hands on Testing

Describe your testing of the PR. Emphasize testing not reflected in the code. Attach protocols, logs, screenshots and any other assets that support your testing.

Changelog

List changes introduced by this PR considering future developers and the end user. Give careful thought and clear documentation to breaking changes.

Review requests

  • What do you need from reviewers to feel confident this PR is ready to merge?
  • Ask questions.

Risk assessment

  • Indicate the level of attention this PR needs.
  • Provide context to guide reviewers.
  • Discuss trade-offs, coupling, and side effects.
  • Look for the possibility, even if you think it's small, that your change may affect some other part of the system.
    • For instance, changing return tip behavior may also change the behavior of labware calibration.
  • How do your unit tests and on hands on testing mitigate this PR's risks and the risk of future regressions?
  • Especially in high risk PRs, explain how you know your testing is enough.

…ateRobotStateTimeline`

This PR adds logic for skipping eager tip dropping if the step returns tips to its tiprack. It also adds eager tip dropping if the pipette is used in the future, but its nozzle configuration differs from its previous use.
@codecov
Copy link

codecov bot commented Nov 25, 2025

Codecov Report

❌ Patch coverage is 72.72727% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.32%. Comparing base (45db548) to head (2cec231).
⚠️ Report is 15 commits behind head on edge.

Files with missing lines Patch % Lines
...c/timelineMiddleware/generateRobotStateTimeline.ts 72.72% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #20246      +/-   ##
==========================================
- Coverage   56.38%   56.32%   -0.06%     
==========================================
  Files        3622     3626       +4     
  Lines      301015   301323     +308     
  Branches    42247    42257      +10     
==========================================
+ Hits       169728   169734       +6     
- Misses     131061   131363     +302     
  Partials      226      226              
Flag Coverage Δ
protocol-designer 19.28% <72.72%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...c/timelineMiddleware/generateRobotStateTimeline.ts 86.60% <72.72%> (-2.61%) ⬇️

... and 26 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants