Skip to content

Conversation

@sparrowDom
Copy link
Member

WIP

Code Change Checklist

To be completed before internal review begins:

  • The contract code is complete
  • Executable deployment file
  • Fork tests that test after the deployment file runs
  • Unit tests *if needed
  • The owner has done a full checklist review of the code + tests

Internal review:

  • Two approvals by internal reviewers

Deploy checklist

Two reviewers complete the following checklist:

- [ ] All deployed contracts are listed in the deploy PR's description
- [ ] Deployed contract's verified code (and all dependencies) match the code in master
- [ ] Contract constructors have correct arguments
- [ ] The transactions that interacted with the newly deployed contract match the deploy script.
- [ ] Governance proposal matches the deploy script
- [ ] Smoke tests pass after fork test execution of the governance proposal

@codecov
Copy link

codecov bot commented Dec 5, 2025

Codecov Report

❌ Patch coverage is 11.62791% with 38 lines in your changes missing coverage. Please review.
✅ Project coverage is 8.50%. Comparing base (7fdf6e1) to head (7630f6d).

Files with missing lines Patch % Lines
...ts/strategies/crossChain/YearnV3MasterStrategy.sol 2.70% 36 Missing ⚠️
...cts/strategies/crossChain/YearnV3SlaveStrategy.sol 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #2713       +/-   ##
==========================================
- Coverage   41.10%   8.50%   -32.61%     
==========================================
  Files         126     130        +4     
  Lines        5778    5821       +43     
  Branches     1537    1555       +18     
==========================================
- Hits         2375     495     -1880     
- Misses       3401    5324     +1923     
  Partials        2       2               

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants