feat: fix bold formatting removal when unchecking checkboxes (#65)

* Initial plan

* Fix bold formatting preservation when unchecking checkboxes

Co-authored-by: PKief <[email protected]>

---------

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: PKief <[email protected]>

Author: Copilot

src/test/spec/checkbox/toggleCheckbox.spec.ts

@@ -101,4 +101,60 @@ describe('toggle checkboxes', () => {
 
     assert.strictEqual(content, expectedResult);
   });
+
+  it('should preserve bold formatting when unchecking', async () => {
+    // create new document with bold formatting
+    const newDocument = await vscode.workspace.openTextDocument({
+      content: '[x] ~~*this is a **bold** action*~~ [2023-12-01]',
+      language: 'markdown',
+    });
+    await vscode.window.showTextDocument(newDocument);
+
+    // position cursor on the checkbox line
+    const editor = getEditor();
+    const startPosition = new vscode.Position(0, 0);
+    const endPosition = new vscode.Position(0, 0);
+    const newSelection = new vscode.Selection(startPosition, endPosition);
+    editor.selection = newSelection;
+
+    await toggleCheckbox();
+
+    const content = editor.document.getText();
+    const expectedResult = '[ ] this is a **bold** action';
+
+    assert.strictEqual(content, expectedResult);
+  });
+
+  it('should preserve bold formatting when toggling checkbox', async () => {
+    // create new document with bold formatting
+    const newDocument = await vscode.workspace.openTextDocument({
+      content: '[ ] this is a **bold** action',
+      language: 'markdown',
+    });
+    await vscode.window.showTextDocument(newDocument);
+
+    // position cursor on the checkbox line
+    const editor = getEditor();
+    const startPosition = new vscode.Position(0, 0);
+    const endPosition = new vscode.Position(0, 0);
+    const newSelection = new vscode.Selection(startPosition, endPosition);
+    editor.selection = newSelection;
+
+    // check the checkbox
+    await toggleCheckbox();
+
+    let content = editor.document.getText();
+    const dateNow = getDateString(new Date());
+    let expectedResult = `[X] ~~*this is a **bold** action*~~ [${dateNow}]`;
+
+    assert.strictEqual(content, expectedResult);
+
+    // now uncheck it - this should preserve the bold formatting
+    await toggleCheckbox();
+
+    content = editor.document.getText();
+    expectedResult = '[ ] this is a **bold** action';
+
+    assert.strictEqual(content, expectedResult);
+  });
 });

src/toggleCheckbox.ts

@@ -123,7 +123,55 @@ const markField = (
         newText
       );
     } else if (lhc && lhc.checked) {
-      let newText = textWithoutCheckbox.replace(/~~/g, '').replace(/\*/g, '');
+      let newText = textWithoutCheckbox;
+      
+      // Remove strikethrough formatting (outermost ~~ pairs) if present
+      if (strikeThroughWhenChecked && newText.startsWith('~~')) {
+        // Remove the date first to avoid interfering with strikethrough detection
+        let tempText = newText;
+        let datePart = '';
+        if (dateWhenChecked) {
+          const dateMatch = tempText.match(/(\s+\[[^[]+?\])$/);
+          if (dateMatch) {
+            datePart = dateMatch[1];
+            tempText = tempText.substring(0, tempText.length - datePart.length);
+          }
+        }
+        
+        // Now remove strikethrough from the main text
+        if (tempText.startsWith('~~') && tempText.endsWith('~~')) {
+          tempText = tempText.substring(2, tempText.length - 2);
+        }
+        
+        newText = tempText + datePart;
+      }
+      
+      // Remove italic formatting (outermost * pairs) if present
+      if (italicWhenChecked) {
+        // Remove the date first to avoid interfering with italic detection
+        let tempText = newText;
+        let datePart = '';
+        if (dateWhenChecked) {
+          const dateMatch = tempText.match(/(\s+\[[^[]+?\])$/);
+          if (dateMatch) {
+            datePart = dateMatch[1];
+            tempText = tempText.substring(0, tempText.length - datePart.length);
+          }
+        }
+        
+        // Now remove italic from the main text only if it wraps the entire content
+        if (tempText.startsWith('*') && tempText.endsWith('*') && tempText.length > 2) {
+          // Check if these are the outermost asterisks (not part of **bold**)
+          const inner = tempText.substring(1, tempText.length - 1);
+          // Only remove if the inner content doesn't start/end with * (avoiding **bold** cases)
+          if (!inner.startsWith('*') && !inner.endsWith('*')) {
+            tempText = inner;
+          }
+        }
+        
+        newText = tempText + datePart;
+      }
+      
       // remove the date string
       if (dateWhenChecked) {
         newText = newText.replace(/\s+\[[^[]+?\]$/, '') + whitespace;