This repository was archived by the owner on Jan 24, 2018. It is now read-only.
Allowing variables (constants) in attributes #726
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is my first pull request ever. Excuse all my mistakes (you are welcome to point them out though). Now properties can be expressed as variables, which will use the constants defined in the init. e.g. val(--constantname) = _constantname Example usage: data-top="margin-top: val(--constantname)px;"
Owner
|
This needs further discussion. It mixes two completely different concept (I would not reuse the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my first pull request ever. Excuse all my mistakes (you are welcome to point them out though).
Now properties can be expressed as variables, which will use the constants defined in the init.
e.g.
val(--constantname) = _constantname
Example usage:
data-top="margin-top: val(--constantname)px;"