Skip to content

[orion-based] [WIP] Commands Implementation #1679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 119 commits into
base: orion-based
Choose a base branch
from
Draft

[orion-based] [WIP] Commands Implementation #1679

wants to merge 119 commits into from

Conversation

@kevzhao2
Copy link
Member

@kevzhao2 kevzhao2 commented Sep 30, 2019

This PR aims to implement TShock's command subsystem, as roughly laid out in #1677. This is currently a work-in-progress; I will provide a write-up once I think it's done.

@kevzhao2
Start command service implementation.
5ec96f0
@kevzhao2
Add Pure contract to FindCommands.
29265ef
@kevzhao2
Add JetBrains.Annotations.
14e4b6e
@kevzhao2
Add [MeansImplicitUse] to CommandHandlerAttribute.
5e0e692
@kevzhao2
Implement TShockCommandService and tests.
e2af163
@kevzhao2
Add IArgumentParser interface and Int32Parser implementation.
9bf28b4
@kevzhao2
Rename Parsing to Parsers.
07ca5fe
@kevzhao2
Adjust Parsing to Parsers namespace.
31ad6fe
@kevzhao2
Add StringParser.
ebc683e
@kevzhao2
Add non-generic IArgumentParser.
bc99d33
@kevzhao2
Add RegisterParser to ICommandService interface.
3ea5469
@kevzhao2
Add ParseOptionsAttribute.
043befc
@kevzhao2
Add ParseOptions to parse a string to the end of the input.
fd36f11
@kevzhao2
Add strongly-typed RegisterParser extension method.
8fe4653
@kevzhao2
Add parsers in TShockCommandService constructor.
f7ea6c3
@kevzhao2
Remove [NotNull]s.
4b99642
@kevzhao2
Begin implementation of ICommand.Invoke.
ca8fbc2
@maka-albarn
Copy link

maka-albarn bot commented Sep 30, 2019

Thanks for the pull request! TShock's maintainers would like you to go ahead and give yourself credit by updating the CHANGELOG.md as soon as you can. Your pull request will likely not be accepted without this. This both helps us document changes to TShock, as well as give you credit for your work. You deserve it, so go take credit! ✨

@kevzhao2 kevzhao2 added the orion-based Applies to anything which deals with the new version of TShock on Orion. label Sep 30, 2019
@kevzhao2 kevzhao2 changed the title WIP: Commands Implementation WIP: [orion-based] Commands Implementation Sep 30, 2019
@kevzhao2 kevzhao2 changed the title WIP: [orion-based] Commands Implementation [orion-based] [WIP] Commands Implementation Sep 30, 2019
kevzhao2 added 28 commits October 8, 2019 19:55
@kevzhao2
Move default interface methods in ICommandSender out.
faa6378
@kevzhao2
Add more validation.
3f370bb
@kevzhao2
Switch to attribute-based parsing.
bcbe2ad
@kevzhao2
Implement localizable CommandHandlerAttribute.
6dbc945
@kevzhao2
Add ArgumentNullException xmldoc to ResourceType.
60c13e5
@kevzhao2
Implement extra functionality for help command.
f32af9d
@kevzhao2
Localize log messages.
5851cf1
@kevzhao2
Undo test change.
976777e
@kevzhao2
Show usage text on command parsing errors.
e9756d7
@kevzhao2
Move exceptions into the Exceptions namespace.
d9b549d
@kevzhao2
Implement DoubleParser.
c70dd79
@kevzhao2
Make TShockCommandService thread-safe.
04f761f
@kevzhao2
Improve GetValueOrDefault.
9304460
@kevzhao2
Persist the PlayerCommandSender.
13bb612
@kevzhao2
Strip leading / from /help argument.
a6a6a2f
@kevzhao2
Switch to string and ReadOnlySpan<char> when necessary.
f1737f1
@kevzhao2
Remove HandlerObject and Handler from ICommand as those are implement…
ed7c569 
…ation details.
@kevzhao2
Clean up implementation and fix failing tests.
b6cf6f5
@kevzhao2
Implement ShouldBeLogged for sensitive commands.
45ac981
@kevzhao2
Refactor out commands into a separate module of functionality.
c2e5bbe
@kevzhao2
Add tests for TShockPlugin.
3b40693
@kevzhao2
Localize Terraria command -> command map.
2f98903
@kevzhao2
Create comprehensive logging sub-library.
a717c63
@kevzhao2
Remove {Properties} from ConsoleCommandSender log.
9c34a3f
@kevzhao2
Update to new Orion features.
312c394
@kevzhao2
Update to new Orion v2 branch.
d7723db
@kevzhao2
Code cleanup.
bad3e4e
@kevzhao2
Simplify module Dispose pattern.
9ad0be9
@hakusaro hakusaro marked this pull request as draft May 12, 2020 08:22
@ZakFahey ZakFahey mentioned this pull request May 24, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

orion-based Applies to anything which deals with the new version of TShock on Orion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kevzhao2