refactor: replace manual byte swapping with htons/ntohs for endianness handling

Author: baptleduc

drivers/ads1115/ads1115.c

@@ -23,6 +23,7 @@
 #include "ads1115_internal.h"
 
 #include "periph/i2c.h"
+#include "byteorder.h"
 
 #define ENABLE_DEBUG 0
 #include "debug.h"
@@ -69,25 +70,23 @@ int ads1115_init(ads1115_t *dev, const ads1115_params_t *params)
     i2c_acquire(DEV);
 
     // Test communication
-    uint8_t test_conf[2] = { 0x00, ADS1115_CONF_TEST_VALUE };
-    if (i2c_write_regs(DEV, ADDR, ADS1115_REG_CONFIG, test_conf, 2, 0) < 0) {
+    uint16_t test_conf = htons(ADS1115_CONF_TEST_VALUE);
+    if (i2c_write_regs(DEV, ADDR, ADS1115_REG_CONFIG, &test_conf, sizeof(test_conf), 0) < 0) {
         DEBUG("[ads1115] init - error: write test failed\n");
         res = ADS1115_NODEV;
     }
 
-    uint8_t reg[2];
-    if (i2c_read_regs(DEV, ADDR, ADS1115_REG_CONFIG, reg, 2, 0) < 0 ||
-        (((uint16_t)reg[0] << 8) | reg[1]) != ADS1115_CONF_TEST_VALUE) {
-        DEBUG("[ads1115] init - error: read test failed (reg=%02x%02x)\n", reg[0], reg[1]);
+    uint16_t reg;
+    if (i2c_read_regs(DEV, ADDR, ADS1115_REG_CONFIG, &reg, sizeof(reg), 0) < 0 ||
+        ntohs(reg) != ADS1115_CONF_TEST_VALUE) {
+        DEBUG("[ads1115] init - error: read test failed (reg=%04x)\n", ntohs(reg));
         res = ADS1115_NOI2C;
         goto release;
     }
 
     // Apply actual configuration
-    uint16_t conf = _build_config_reg(&dev->params);
-    uint8_t conf_bytes[2] = { conf >> 8, conf & 0xFF };
-
-    if (i2c_write_regs(DEV, ADDR, ADS1115_REG_CONFIG, conf_bytes, 2, 0) < 0) {
+    uint16_t conf = htons(_build_config_reg(&dev->params));
+    if (i2c_write_regs(DEV, ADDR, ADS1115_REG_CONFIG, &conf, sizeof(conf), 0) < 0) {
         DEBUG("[ads1115] init - error: setting config failed\n");
         res = ADS1115_NOI2C;
         goto release;
@@ -109,22 +108,21 @@ int ads1115_set_ain_ch_input(ads1115_t *dev, ads1115_mux_t mux)
     i2c_acquire(DEV);
 
     // Read current configuration
-    uint8_t reg[2];
-    if (i2c_read_regs(DEV, ADDR, ADS1115_REG_CONFIG, reg, 2, 0) < 0) {
+    uint16_t reg;
+    if (i2c_read_regs(DEV, ADDR, ADS1115_REG_CONFIG, &reg, sizeof(reg), 0) < 0) {
         i2c_release(DEV);
         goto release;
     }
 
     // Update MUX bits
-    uint16_t conf = ((uint16_t)reg[0] << 8) | reg[1];
+    uint16_t conf = ntohs(reg);
     conf &= ~(0x07 << ADS1115_CONF_MUX_BIT);    // Clear MUX bits
     conf |= (mux << ADS1115_CONF_MUX_BIT);      // Set new MUX
 
     // Write back updated configuration
-    reg[0] = conf >> 8;
-    reg[1] = conf & 0xFF;
+    reg = htons(conf);
 
-    if (i2c_write_regs(DEV, ADDR, ADS1115_REG_CONFIG, reg, 2, 0) < 0) {
+    if (i2c_write_regs(DEV, ADDR, ADS1115_REG_CONFIG, &reg, sizeof(reg), 0) < 0) {
         goto release;
     }
 
@@ -142,17 +140,17 @@ int ads1115_read_conversion(ads1115_t *dev, uint16_t *value)
     assert(dev && value);
 
     int res = ADS1115_NOI2C;
-    uint8_t buf[2];
+    uint16_t buf;
 
     i2c_acquire(DEV);
 
     // Read conversion register
-    if (i2c_read_regs(DEV, ADDR, ADS1115_REG_CONVERSION, buf, 2, 0) < 0) {
+    if (i2c_read_regs(DEV, ADDR, ADS1115_REG_CONVERSION, &buf, sizeof(buf), 0) < 0) {
         goto release;
     }
 
     // Combine bytes into a single value
-    *value = ((int16_t)buf[0] << 8) | buf[1];
+    *value = ntohs(buf);
     res = ADS1115_OK;
 
 release:
@@ -163,5 +161,5 @@ int ads1115_read_conversion(ads1115_t *dev, uint16_t *value)
 int ads1115_convert_to_mv(ads1115_t *dev, uint16_t value)
 {
     assert(dev);
-    return 1000 * value * _ads1115_get_pga_voltage(dev->params.pga) / (1 << 15); // Msb is sign bit
+    return value * _ads1115_get_pga_voltage(dev->params.pga) / (1 << 15); // Msb is sign bit
 }