bug: Reactions not shown

[paulchen]

Describe the Bug

The users that reacted to a message with a particular emoji are not shown.

Steps to Reproduce

1. React to a message
2. Long tap on the reaction emoji
3. Switch to the second tab

Expected Behavior

A list of users appears.

Actual Behavior

The list is empty:

However, the first tab is properly populated:

Rocket.Chat Server Version

7.9.0

Rocket.Chat App Version

4.63.0.96963

Device Name

Google Pixel 8

OS Version

Android 16

Additional Context

I host two instances of Rocket.Chat, I can reproduce the issue on both of them. However, I'm unable to reproduce it on open.rocket.chat.

[diegolmello]

@paulchen That's strange and we can't really reproduce it.
We're going to think about something, but try to isolate this behavior in the meantime.
I'm not very confident we can find it only with the current description 😕

[paulchen]

but try to isolate this behavior in the meantime.

I'll try my best. I managed to get the app running in Metro. I can reproduce it there. Using DevTools I can trace that the components for the second tab are created, but I have yet to find out why they are missing from what eventually gets rendered.

EDIT: At least I found out that it works when enabling the Option "Use Real Names" in Workspace -> Settings -> Layout -> User Interface.

When changing that option, it may be necessary to use "Clear local workspace cache" from the app settings.

[paulchen]

At least I found out that it works when enabling the Option "Use Real Names" in Workspace -> Settings -> Layout -> User Interface.

This in fact triggers the issue.

When "Use Real Names" is enabled, the relevant part of the message returned by the REST API looks like this:

"reactions": {
    ":thumbsup:": {
        "usernames": [
            "paulchen"
        ],  
        "names": [
            "xx"
        ]   
    }   
}

When disabling that option, this changes to:

"reactions": {
    ":thumbsup:": {
        "usernames": [
            "paulchen"
        ]
    }
}

As a result, in app/containers/ReactionsList/index.tsx#L40, reaction.names is undefined. Hence, route.names in app/containers/ReactionsList/index.tsx#L61 is undefined as well and the condition for the if statement always evaluates to false.

Changing line 61 from

if (route.emoji && route.usernames && route.names) {

to

if (route.emoji && route.usernames) {

solves the issue:

However, as I'm not sure whether this is a proper fix I don't create a PR.

I also wondered why the tests for the ReactionsList do not fail. I tried to run them and in fact, they do fail, at least on my machine:

However, there are many more tests that fail on my machine so maybe this is just my setup:

[diegolmello]

The issue seems to be around websocket.
Logging data from stream-room-messages returns only usernames

Rocket.Chat.ReactNative/app/lib/methods/subscriptions/room.ts

Line 353 in 77fccac

handleMessageReceived = async (ddpMessage: IDDPMessage) => {

It's something on backend then.
Clearing local cache forces a rest api request and then it works.