chore!: remove stdout logging functionality (#37114)

Co-authored-by: Tasso Evangelista <[email protected]>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

Author: 3 people

.changeset/tough-baboons-wash.md

@@ -0,0 +1,8 @@
+---
+'@rocket.chat/rest-typings': major
+'@rocket.chat/ddp-client': major
+'@rocket.chat/logger': major
+'@rocket.chat/meteor': major
+---
+
+Removes stdout logging functionality, related components and settings

apps/meteor/app/api/server/v1/misc.ts

@@ -23,7 +23,6 @@ import { SystemLogger } from '../../../../server/lib/logger/system';
 import { browseChannelsMethod } from '../../../../server/methods/browseChannels';
 import { spotlightMethod } from '../../../../server/publications/spotlight';
 import { resetAuditedSettingByUser, updateAuditedByUser } from '../../../../server/settings/lib/auditedSettingUpdates';
-import { getLogs } from '../../../../server/stream/stdout';
 import { passwordPolicy } from '../../../lib/server';
 import { notifyOnSettingChangedById } from '../../../lib/server/lib/notifyListener';
 import { settings } from '../../../settings/server';
@@ -437,15 +436,6 @@ API.v1.addRoute(
  *              schema:
  *                $ref: '#/components/schemas/ApiFailureV1'
  */
-API.v1.addRoute(
-	'stdout.queue',
-	{ authRequired: true, permissionsRequired: ['view-logs'] },
-	{
-		async get() {
-			return API.v1.success({ queue: getLogs() });
-		},
-	},
-);
 
 declare module '@rocket.chat/rest-typings' {
 	// eslint-disable-next-line @typescript-eslint/naming-convention

apps/meteor/client/views/admin/routes.tsx

@@ -69,8 +69,8 @@ declare module '@rocket.chat/ui-contexts' {
 			pattern: '/admin/invites';
 		};
 		'admin-view-logs': {
-			pathname: '/admin/reports';
-			pattern: '/admin/reports';
+			pathname: '/admin/analytic-reports';
+			pattern: '/admin/analytic-reports';
 		};
 		'admin-permissions': {
 			pathname: `/admin/permissions${`/${string}` | ''}${`/${string}` | ''}`;
@@ -193,7 +193,7 @@ registerAdminRoute('/invites', {
 	component: lazy(() => import('./invites/InvitesRoute')),
 });
 
-registerAdminRoute('/reports', {
+registerAdminRoute('/analytic-reports', {
 	name: 'admin-view-logs',
 	component: lazy(() => import('./viewLogs/ViewLogsRoute')),
 });

apps/meteor/client/views/admin/sidebarItems.ts

@@ -108,7 +108,7 @@ export const {
 		permissionGranted: (): boolean => hasPermission('run-import'),
 	},
 	{
-		href: '/admin/reports',
+		href: '/admin/analytic-reports',
 		i18nLabel: 'Reports',
 		icon: 'post',
 		permissionGranted: (): boolean => hasPermission('view-logs'),

apps/meteor/client/views/admin/viewLogs/ServerLogs.tsx

@@ -1,30 +1,18 @@
-import { Margins, Tabs } from '@rocket.chat/fuselage';
 import type { ReactElement } from 'react';
-import { useState } from 'react';
 import { useTranslation } from 'react-i18next';
 
 import AnalyticsReports from './AnalyticsReports';
-import ServerLogs from './ServerLogs';
 import { Page, PageHeader, PageContent } from '../../../components/Page';
 
 const ViewLogsPage = (): ReactElement => {
 	const { t } = useTranslation();
-	const [tab, setTab] = useState('Logs');
 
 	return (
 		<Page background='tint'>
-			<PageHeader title={t('Reports')} />
-			<Margins blockEnd={24}>
-				<Tabs>
-					<Tabs.Item onClick={() => setTab('Logs')} selected={tab === 'Logs'}>
-						{t('Logs')}
-					</Tabs.Item>
-					<Tabs.Item onClick={() => setTab('Analytics')} selected={tab === 'Analytics'}>
-						{t('Analytic_reports')}
-					</Tabs.Item>
-				</Tabs>
-			</Margins>
-			<PageContent>{tab === 'Logs' ? <ServerLogs /> : <AnalyticsReports />}</PageContent>
+			<PageHeader title={t('Analytic_reports')} />
+			<PageContent>
+				<AnalyticsReports />
+			</PageContent>
 		</Page>
 	);
 };

apps/meteor/client/views/admin/viewLogs/ViewLogsPage.tsx

@@ -1,4 +1,4 @@
-import { setQueueLimit, logLevel, type LogLevelSetting } from '@rocket.chat/logger';
+import { logLevel, type LogLevelSetting } from '@rocket.chat/logger';
 import { Settings } from '@rocket.chat/models';
 
 import type { ICachedSettings } from '../../app/settings/server/CachedSettings';
@@ -14,10 +14,4 @@ export async function configureLogLevel(settings: ICachedSettings) {
 			logLevel.emit('changed', String(value) as LogLevelSetting);
 		}
 	});
-
-	settings.watch('Log_View_Limit', (value) => {
-		if (typeof value === 'number') {
-			setQueueLimit(value);
-		}
-	});
 }

apps/meteor/server/configuration/configureLogLevel.ts

@@ -39,8 +39,6 @@ export class NotificationsModule {
 
 	public readonly streamLivechatQueueData: IStreamer<'livechat-inquiry-queue-observer'>;
 
-	public readonly streamStdout: IStreamer<'stdout'>;
-
 	public readonly streamRoomData: IStreamer<'room-data'>;
 
 	public readonly streamLocal: IStreamer<'local'>;
@@ -60,7 +58,6 @@ export class NotificationsModule {
 		this.streamIntegrationHistory = new this.Streamer('integrationHistory');
 		this.streamLivechatRoom = new this.Streamer('livechat-room');
 		this.streamLivechatQueueData = new this.Streamer('livechat-inquiry-queue-observer');
-		this.streamStdout = new this.Streamer('stdout');
 		this.streamRoomData = new this.Streamer('room-data');
 		this.streamPresence = StreamPresence.getInstance(Streamer, 'user-presence');
 		this.streamRoomMessage = new this.Streamer('room-messages');
@@ -348,14 +345,6 @@ export class NotificationsModule {
 			return this.userId ? Authorization.hasPermission(this.userId, 'view-l-room') : false;
 		});
 
-		this.streamStdout.allowWrite('none');
-		this.streamStdout.allowRead(async function () {
-			if (!this.userId) {
-				return false;
-			}
-			return Authorization.hasPermission(this.userId, 'view-logs');
-		});
-
 		this.streamRoomData.allowWrite('none');
 		this.streamRoomData.allowRead(async function (rid) {
 			if (!this.userId) {

apps/meteor/server/modules/notifications/notifications.module.ts

@@ -20,9 +20,6 @@ export const createLogSettings = () =>
 			],
 			public: true,
 		});
-		await this.add('Log_View_Limit', 1000, {
-			type: 'int',
-		});
 
 		await this.add('Log_Trace_Methods', false, {
 			type: 'boolean',

apps/meteor/server/settings/logs.ts

@@ -28,5 +28,6 @@ import './v319';
 import './v320';
 import './v321';
 import './v322';
+import './v324';
 
 export * from './xrun';