feat: update to upstream @floating-ui/dom@1.7.0 (#136)

github-actions[bot] · DanielleHuisman · web-flow · commit cdda32f60d11 · 2025-05-04T19:10:22.000Z
* feat: update to upstream @floating-ui/dom@1.7.0

* fix: correct position when document scrollbar is on left side with fixed strategy

---------

Co-authored-by: github-actions[bot] &lt;github-actions[bot]@users.noreply.github.com&gt;
Co-authored-by: Daniëlle Huisman &lt;danielle@huisman.me&gt;
diff --git a/packages/dom/src/utils/get_rect_relative_to_offset_parent.rs b/packages/dom/src/utils/get_rect_relative_to_offset_parent.rs
@@ -32,6 +32,12 @@ pub fn get_rect_relative_to_offset_parent(
     let mut scroll = NodeScroll::new(0.0);
     let mut offsets = Coords::new(0.0);
 
+    // If the <body> scrollbar appears on the left (e.g. RTL systems).
+    // Use Firefox with layout.scrollbar.side = 3 in about:config to test this.
+    let set_left_rtl_scrollbar_offset = |offsets: &mut Coords| {
+        offsets.x = get_window_scroll_bar_x(&document_element, None);
+    };
+
     #[allow(clippy::nonminimal_bool)]
     if is_offset_parent_an_element || (!is_offset_parent_an_element && !is_fixed) {
         if get_node_name((&offset_parent).into()) != "body"
@@ -52,13 +58,15 @@ pub fn get_rect_relative_to_offset_parent(
                 offsets.y = offset_rect.y + offset_parent.client_top() as f64;
             }
             DomElementOrWindow::Window(_) => {
-                // If the <body> scrollbar appears on the left (e.g. RTL systems).
-                // Use Firefox with layout.scrollbar.side = 3 in about:config to test this.
-                offsets.x = get_window_scroll_bar_x(&document_element, None);
+                set_left_rtl_scrollbar_offset(&mut offsets);
             }
         }
     }
 
+    if is_fixed && !is_offset_parent_an_element {
+        set_left_rtl_scrollbar_offset(&mut offsets);
+    }
+
     let html_offset = if !is_offset_parent_an_element && !is_fixed {
         get_html_offset(&document_element, &scroll, None)
     } else {
diff --git a/upstream.toml b/upstream.toml
@@ -1,5 +1,5 @@
 [releases]
 core = "1.7.0"
-dom = "1.6.13"
+dom = "1.7.0"
 utils = "0.2.9"
 vue = "1.1.6"
