Review of packaging episode

[steve-crouch]

• Installing poetry: “This installer is deprecated. Poetry versions installed using this script will not be able to use 'self update' command to upgrade to 1.2.0a1 or later.” - worth worrying about?
• Just FYI: installation changes “$HOME/.profile”, but this isn’t reloaded on the VM it seems
• “If you don’t get this output, then we should try activating it manually and checking again:” - in this case you could also mention this would be needed every time a terminal is started?
• PEP 518 mention - I think this may be the first mention of a PEP, perhaps a callout very briefly explaining what one is? Our ISWC material has a bit of text on what PEPs are you could reuse (see coding conventions episode)
• “cd 2020-se-day4/code” - remove year prefix
• Perhaps worth explicitly stating that Poetry examines the current Python environment (i.e. venv in this case) when you do poetry init?
• After adding numpy, matplotlib and pylint, could also point them to updated pyproject.toml file to illustrate the changes?
• "mv poetry_project poetry_project_jgraham” - doesn’t match the “inflammation-jgraham” package name specified during poetry init (unless I’ve missed something)? Would also need to change “pip3 install dist/poetry_project*.whl” too
• “Once we’ve got out pyproject.toml configuration” - “out” to “our”
• “ you may receive an email asking you to verify the account creation.” - I had to click on a link at the top of the webpage after account creation to verify my account via email - change to reflect this?
• “If we now go to https://test.pypi.org and search for our package name” - took about 3-4 mins to show up, so might want to mention
• “pip3 install -i https://test.pypi.org/simple/ ” - it mentioned I already had it installed from previous pip3 install of it, so maybe get them to do a “pip3 uninstall ” first?