Add rubocop fixes

Author: Frenje123

Gemfile

@@ -1,4 +1,6 @@
-source "http://rubygems.org"
+# frozen_string_literal: true
+
+source 'http://rubygems.org'
 
 # Declare your gem's dependencies in samfundet_auth.gemspec.
 # Bundler will treat runtime dependencies like base dependencies, and

Rakefile

@@ -1,4 +1,6 @@
 #!/usr/bin/env rake
+# frozen_string_literal: true
+
 begin
   require 'bundler/setup'
 rescue LoadError
@@ -20,11 +22,9 @@ RDoc::Task.new(:rdoc) do |rdoc|
   rdoc.rdoc_files.include('lib/**/*.rb')
 end
 
-APP_RAKEFILE = File.expand_path("../test/dummy/Rakefile", __FILE__)
+APP_RAKEFILE = File.expand_path('test/dummy/Rakefile', __dir__)
 load 'rails/tasks/engine.rake'
 
-
-
 Bundler::GemHelper.install_tasks
 
 require 'rake/testtask'
@@ -36,5 +36,4 @@ Rake::TestTask.new(:test) do |t|
   t.verbose = false
 end
 
-
-task :default => :test
+task default: :test

app/models/member.rb

@@ -1,16 +1,16 @@
+# frozen_string_literal: true
+
 class Member < ActiveRecord::Base
   self.primary_key = :medlem_id
 
-  has_many :members_roles, :dependent => :destroy
-  has_many :roles, :through => :members_roles
+  has_many :members_roles, dependent: :destroy
+  has_many :roles, through: :members_roles
 
-  attr_accessor :passord if %w(production staging).include? Rails.env
+  attr_accessor :passord if %w[production staging].include? Rails.env
 
   validates_presence_of :fornavn, :etternavn, :mail, :telefon
 
-  if Rails.env.development?
-    validates_presence_of :passord
-  end
+  validates_presence_of :passord if Rails.env.development?
 
   def firstname
     fornavn
@@ -25,7 +25,7 @@ def full_name
   end
 
   def self.authenticate(member_id_or_email, password)
-    if %w(production staging).include? Rails.env
+    if %w[production staging].include? Rails.env
       authenticate_production member_id_or_email, password
     else
       authenticate_development member_id_or_email, password
@@ -37,22 +37,20 @@ def self.authenticate(member_id_or_email, password)
   def self.authenticate_production(member_id_or_email, password)
     Rails.logger.silence do # Prevents passwords from showing up in the logs.
       member_id = connection.select_value sanitize_sql([
-                                                           "SELECT * FROM sett_lim_utvidet_medlemsinfo(?, ?)",
-                                                           member_id_or_email.to_s,
-                                                           password
+                                                         'SELECT * FROM sett_lim_utvidet_medlemsinfo(?, ?)',
+                                                         member_id_or_email.to_s,
+                                                         password
                                                        ])
-      unless member_id.nil?
-        Member.find member_id
-      end
+      Member.find member_id unless member_id.nil?
     end
   end
 
   def self.authenticate_development(member_id_or_email, password)
     # There are no SQL standard for lower case search,
     # and that's why there's no help from ruby or rails.
     member = Member.find_by_medlem_id(member_id_or_email) ||
-        Member.where("lower(mail) = ?", member_id_or_email.downcase).first
+             Member.where('lower(mail) = ?', member_id_or_email.downcase).first
 
-    member if member and member.passord == password
+    member if member && (member.passord == password)
   end
 end

app/models/members_role.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class MembersRole < ActiveRecord::Base
   validates_presence_of :member_id
   validates_presence_of :role_id

app/models/role.rb

@@ -1,13 +1,15 @@
+# frozen_string_literal: true
+
 class Role < ActiveRecord::Base
-  validates_format_of :title, :with => /\A[a-z0-9\_\-]+\z/
+  validates_format_of :title, with: /\A[a-z0-9\_\-]+\z/
   validates_presence_of :name, :description
 
   attr_readonly :title
 
   default_scope { order(:title) }
 
-  has_many :members_roles, :dependent => :destroy
-  has_many :members, :through => :members_roles
+  has_many :members_roles, dependent: :destroy
+  has_many :members, through: :members_roles
   has_many :roles
   belongs_to :group
   belongs_to :role

config/routes.rb

@@ -1,2 +1,4 @@
+# frozen_string_literal: true
+
 SamfundetAuth::Engine.routes.draw do
 end

db/migrate/20121031220629_create_members.rb

@@ -1,6 +1,8 @@
+# frozen_string_literal: true
+
 class CreateMembers < ActiveRecord::Migration
   def up
-    create_table :members, :primary_key => :medlem_id do |t|
+    create_table :members, primary_key: :medlem_id do |t|
       t.string :fornavn
       t.string :etternavn
       t.string :mail

db/migrate/20121031220750_create_roles.rb

@@ -1,10 +1,12 @@
+# frozen_string_literal: true
+
 class CreateRoles < ActiveRecord::Migration
   def up
     create_table :roles do |t|
       t.string     :name  # The name is a generic name of that type of role. E.g. «Gjengsjef» is a name.
       t.string     :title # The title of a role is unique and the properties gained from a role depends on its title. E.g. «mg_gjengsjef» is a title.
       t.text       :description
-      t.boolean    :show_in_hierarchy, :default => false
+      t.boolean    :show_in_hierarchy, default: false
       t.references :role
       t.references :group
 

db/migrate/20121031220820_create_members_roles.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class CreateMembersRoles < ActiveRecord::Migration
   def up
     create_table :members_roles do |t|

db/migrate/20140322161444_add_foreign_keys_for_roles_and_member_roles.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class AddForeignKeysForRolesAndMemberRoles < ActiveRecord::Migration
   def up
     add_foreign_key :roles, :roles