Fix QA tests: add compat entries and fix piracy issues

- Added comprehensive compat entries for all test dependencies
- Fixed piracy by treating DDEProblem as own in Aqua tests
- Fixed implicit imports by using qualified access for solve and init
- Fixed initialize! calls to use DiffEqBase instead of OrdinaryDiffEqCore (owner module)

Author: ChrisRackauckas

src/DelayDiffEq.jl

@@ -74,10 +74,10 @@ include("utils.jl")
 
 # Default solver for DDEProblems
 function SciMLBase.__solve(prob::DDEProblem; kwargs...)
-    solve(prob, MethodOfSteps(DefaultODEAlgorithm()); kwargs...)
+    SciMLBase.solve(prob, MethodOfSteps(DefaultODEAlgorithm()); kwargs...)
 end
 function SciMLBase.__init(prob::DDEProblem; kwargs...)
-    init(prob, MethodOfSteps(DefaultODEAlgorithm()); kwargs...)
+    DiffEqBase.init(prob, MethodOfSteps(DefaultODEAlgorithm()); kwargs...)
 end
 
 end # module

src/integrators/interface.jl

@@ -139,11 +139,11 @@ function OrdinaryDiffEqCore.perform_step!(integrator::DDEIntegrator)
 end
 
 # initialize the integrator
-function OrdinaryDiffEqCore.initialize!(integrator::DDEIntegrator)
+function DiffEqBase.initialize!(integrator::DDEIntegrator)
     ode_integrator = integrator.integrator
 
     # initialize the cache
-    OrdinaryDiffEqCore.initialize!(integrator, integrator.cache)
+    DiffEqBase.initialize!(integrator, integrator.cache)
 
     # copy interpolation data to the ODE integrator
     @inbounds for i in 1:length(integrator.k)
@@ -448,7 +448,7 @@ function DiffEqBase.reinit!(integrator::DDEIntegrator, u0 = integrator.sol.prob.
     end
 
     if reinit_cache
-        OrdinaryDiffEqCore.initialize!(integrator)
+        DiffEqBase.initialize!(integrator)
     end
 
     nothing

src/solve.jl

@@ -415,7 +415,7 @@ function SciMLBase.__init(prob::SciMLBase.AbstractDDEProblem,
         SciMLBase.initialize_dae!(integrator)
         initialize_solution!(integrator)
         OrdinaryDiffEqCore.initialize_callbacks!(integrator, initialize_save)
-        OrdinaryDiffEqCore.initialize!(integrator)
+        DiffEqBase.initialize!(integrator)
     end
 
     # take care of time step dt = 0 and dt with incorrect sign

test/Project.toml

@@ -19,6 +19,21 @@ Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
 Unitful = "1986cc42-f94f-5a68-af5c-568840ba703d"
 
 [compat]
+Aqua = "0.8"
 DDEProblemLibrary = "0.1.2"
+DelayDiffEq = "5"
+DiffEqBase = "6"
+DiffEqCallbacks = "3, 4"
+DiffEqDevTools = "2"
+ExplicitImports = "1"
+FiniteDiff = "2"
+ForwardDiff = "1"
+LinearAlgebra = "1"
+LinearSolve = "2, 3"
 OrdinaryDiffEqCore = "1"
-OrdinaryDiffEqDefault = "1"
+OrdinaryDiffEqDefault = "1"
+Random = "1"
+RecursiveArrayTools = "3"
+SafeTestsets = "0.1"
+Test = "1"
+Unitful = "1"

test/qa/qa_tests.jl

@@ -8,7 +8,9 @@ using DelayDiffEq, Test
     Aqua.test_ambiguities(DelayDiffEq; recursive = false)
     Aqua.test_stale_deps(DelayDiffEq)
     Aqua.test_deps_compat(DelayDiffEq)
-    Aqua.test_piracies(DelayDiffEq)
+    # Allow piracy for the default solver methods
+    Aqua.test_piracies(DelayDiffEq;
+        treat_as_own = [SciMLBase.DDEProblem])
 end
 
 @testset "Explicit Imports Tests" begin