[2.1]: pg "No direct access" error retrieving SMF Files

[sbulen]

Basic Information

Attempting to retrieve SMF FIles, pg issues a "No direct access" error.

Long history here, but the original issue is back.

See also:

• [2.1] Fixes "No direct access..." error when slash at end of message #8783
• [2.1]: Smileys at end of PMs cause 'No Direct Access' Error #8309
• Fix Hacking check by temp converting Fixes #3766 #4411
• Hacking attempt while calling latest-news.js #3766

Steps to reproduce

1. Install pg from current GH
2. Attempt to retrieve SMF files

Expected result

Fresh SMF files

Actual result

No Direct Access error

Version/Git revision

2.1 - current

Database Engine

All

Database Version

pg 14

PHP Version

8.4.5

Logs

https://localhost/pgvan2021/index.php?step=5
D:/wamp64/www/pgvan2021/Sources/ScheduledTasks.php (Line 1164)
Backtrace information

Type of error: Critical

No direct access...

            UPDATE smf_admin_info_files
            SET data = SUBSTRING('
window.smfAnnouncements = [
    {
        subject: ''SMF 2.1.6 has been released'',
        href: ''https://www.simplemachines.org/community/index.php?topic=592074.0'',
        time: ''Jun 26, 2025, 03:39 PM'',
        author: ''Sesquipedalian'',
        message: ''SMF 2.1.6 contains fixes for a few minor (but annoying) bugs that were introduced in 2.1.5. We recommend updating as soon as possible.''
    },
    {
        subject: ''SMF 2.1.5 has been released'',
        href: ''https://www.simplemachines.org/community/index.php?topic=592035.0'',
        time: ''Jun 24, 2025, 04:42 PM'',

Additional Information

No response

[sbulen]

I started looking into this... At first glance, it's not what I expected. The query is dying here due to the semicolon found in the emdash entities:
a patch has been released, addressing a few bugs in smf 2.0.x and smf 1.1.x. we urge all forum administrators to upgrade to smf 2.0.10 or 1.1.21—simply visit the package manager to install the patch.

This is the line that triggers the failure:

SMF/Sources/Subs-Db-postgresql.php

Line 421 in 21d5cb1

if (strpos($clean, '/*') > 2 || strpos($clean, '--') !== false || strpos($clean, ';') !== false)

This is what it's trying to display:

[sbulen]

I am testing a solution, will submit a PR tomorrow.

[sbulen]

This is another one not auto-closed out...