[3.0]: Parsed index always says "partially" completed

[Oldiesmann]

Basic Information

Trying to create a new Parsed search index always reports that the index was only "partially" completed no matter how many times you click "Resume", and in fact on PostgreSQL results in an error.

Steps to reproduce

1. Try creating a parsed search index
2. Click the "Resume" button when it reports that the index was partially created

Expected result

Parsed index created at some point (on my test boards, both of which have only a handful of topics and less than a dozen posts, I'd expect it to be created without having to stop and resume)

Actual result

MariaDB: Index is never created at all.
PostgreSQL: PHP error after clicking resume

Version/Git revision

16fdbf2

Database Engine

All

Database Version

11.4.8-MariaDB-ubu2204 / PostgreSQL 14.19

PHP Version

8.4.14

Logs

PHP Warning: Undefined variable $query_string in /.../Sources/ErrorHandler.php on line 283; 
PHP Fatal error: Uncaught ValueError: array_combine(): Argument #1 ($keys) and argument #2 ($values) must have the same number of elements in /.../Sources/Db/APIs/PostgreSQL.php:754
Stack trace:
#0 /.../Sources/Db/APIs/PostgreSQL.php(754): array_combine()
#1 /.../Sources/ErrorHandler.php(294): SMF\\Db\\APIs\\PostgreSQL->error_insert()
#2 /.../Sources/TaskRunner.php(364): SMF\\ErrorHandler::log()
#3 /.../Sources/ErrorHandler.php(283): SMF\\TaskRunner::handleError()
#4 /.../Sources/TaskRunner.php(382): SMF\\ErrorHandler::log()
#5 [internal function]: SMF\\TaskRunner::handleException()
#6 {main}
 thrown in /.../Sources/Db/APIs/PostgreSQL.php on line 754

Additional Information

No response

[Oldiesmann]

After the fix for the undefined $query_string variable, I now get this when trying to "resume" the creation of the index in 3.0 with PostgreSQL.

PostgreSQL result has already been closed
File
/srv/http/smf/Sources/Db/APIs/PostgreSQL.php
Line
341
URL of page causing the error
http://localhost/smf/index.php/index.php?action=admin;area=managesearch;sa=method


    #0: SMF\Db\APIs\PostgreSQL->free_result()
    Called from /srv/http/smf/Sources/Search/APIs/Parsed.php on line 228
    #1: SMF\Search\APIs\Parsed->getSize()
    Called from /srv/http/smf/Sources/Actions/Admin/Search.php on line 293
    #2: SMF\Actions\Admin\Search->method()
    Called from /srv/http/smf/Sources/Actions/Admin/Search.php on line 102
    #3: SMF\Actions\Admin\Search->execute()
    Called from /srv/http/smf/Sources/ActionTrait.php on line 130
    #4: SMF\Actions\Admin\Search::call()
    Called from /srv/http/smf/Sources/Actions/Admin/ACP.php on line 791
    #5: SMF\Actions\Admin\ACP->execute()
    Called from /srv/http/smf/Sources/Forum.php on line 470
    #6: SMF\Forum->execute()
    Called from /srv/http/smf/index.php on line 149

I'm wondering if the setting we use to indicate that the index hasn't been fully created is not getting updated somewhere.

[Oldiesmann]

Definitely looks like whatever tells SMF the index is completed isn't getting updated. The index size doesn't change no matter how many times I click "resume".

[jdarwood007]

I can't reproduce on native mysql. The index is created. Although it does show partial at one point, refreshing did make it go away.