Matter Switch: default Eve devices to main driver #2534
Merged
+166
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hcarter-775
requested review from
ctowns,
gharveymn,
greens and
nickolas-deboom
|
Channel deleted. |
Test Results 71 files 464 suites 0s ⏱️ Results for commit 9d92306. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 9d92306 |
greens
approved these changes
Nov 10, 2025
drivers/SmartThings/matter-switch/src/switch_handlers/attribute_handlers.lua
Show resolved
Hide resolved
nickolas-deboom
approved these changes
Nov 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
In the case an Eve device supports the Matter 1.3 Electrical Sensor device type, we should use the main driver handling of the cluster instead of the unique sub-driver handling.
To note, the profile being used by default for energy eve devices is
power-energy-powerConsumption, but the new profile (using the main driver) will beplug-power-energy-powerConsumption. These are identical but are differently named. This should not affect anything relevant to the driver, and even in the case an Eve device is re-profiled for whatever reason in the future, this should not break any existing rules as the profile composition remains the same.Summary of Completed Tests
Unit test added to confirm sub-driver is not used in the case that the device supports the Electrical Sensor device type.