Matter Sensor->Switch: Move Bosch Contact Button support to Matter Switch #2544
+322
−438
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hcarter-775
requested review from
KKlimczukS,
ctowns,
gharveymn,
greens and
nickolas-deboom
|
Duplicate profile check: Passed - no duplicate profiles detected. |
|
Invitation URL: |
|
matter-sensor_coverage.xml
matter-switch_coverage.xml
Minimum allowed coverage is Generated by 🐒 cobertura-action against ad38bd9 |
Test Results 71 files 465 suites 0s ⏱️ Results for commit ad38bd9. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
A commit to the Matter Sensor driver a few months ago introduced a sub-driver with button functionality- we generally elect to add sensor logic into Matter Switch rather than the other way around, to promote greater structural clarity and more centralized development.
Therefore, this commit attempts to rectify this organizational error and move the introduced logic into Matter Switch and away from Matter Sensor.
This should not affect currently onboarded Contact Button devices in any way, though their support will be limited to what was introduced at the time of the WWST certification, and future changes will be supported only for devices attached to the Matter Switch driver.
Summary of Completed Tests
Unit tests were added in Matter Switch to ensure proper support continued as expected.