Special Chars in database.url are not decoded

[amenk]

Preconditions

GdprDump Version: 5.0.5
PHP Version: 8.4
Database Version: 10.11.15-MariaDB-deb12

Steps to reproduce

1. Database password is 'test!' which is URL encoded in the database URL (.env.local)

   DATABASE_URL=mysql://user:test%21@127.0.0.1:3306/testdb

2. Config file looks like this:

   database:
    url: '%env(DATABASE_URL)%'

3. Dump script looks like this:

   export $(grep ^DATABASE_URL .env.local | xargs); \
   gdpr-dump

Expected result

Dump is created

Actual result

An exception occurred in the driver: SQLSTATE[HY000] [1045] Access denied for user 'user'@'localhost' (using password: YES)

Possible fix

I think we need a url_decode for the parameters when decoding the URL

Workaround

Hard-code the password using password: 'test!' in the gdpr-dump.yaml

[guvra]

We could use the Doctrine DSN parser instead, but it barely does any validation (e.g. it considers that invalid is a valid URL...).

[amenk]

good idea, would the lack of validation cause us problems?

[guvra]

#196 combines URL validation with doctrine URL parsing

[amenk]

Thank you so much. Shall I test this or just wait for the release? There is not by chance any prebuilt .phar file from GitHub actions for the branch?

[guvra]

Thank you so much. Shall I test this or just wait for the release? There is not by chance any prebuilt .phar file from GitHub actions for the branch?

It would be better if you can test it 👍

There's no prebuilt phar for pull requests, however if you have docker installed it's pretty fast to set up the dev environment and compile it (just clone the repo, checkout the brand fix-database-url-encoding and run make compile c="--locale=en_US").