Change /connect/reviews/add to use JSON instead of formdata

Author: LauraWebdev

src/Controller/API/Connect/APIConnectReviewsController.php

@@ -73,20 +73,20 @@ public function addReview(Request $request, $songID)
     {
         $em = $this->getDoctrine()->getManager();
         $data = [];
-
         $connectToken = $request->query->get('connectToken');
 
-        $reviewRecommend = $request->request->get('recommend');
-        $reviewComment = $request->request->get('comment');
+        // Decode JSON request body
+        $content = json_decode($request->getContent(), true);
+        $reviewRecommend = isset($content['recommended']) ? $content['recommended'] : null;
+        $reviewComment = isset($content['comment']) ? $content['comment'] : '';
 
         // 422 - Parameter Missing
-        if($connectToken == "" || $reviewRecommend == "" || $songID == "") {
+        if($connectToken == "" || $reviewRecommend === null || $songID == "") {
             $response = new JsonResponse(['version' => $this->getParameter('api_version'), 'status' => 422, 'data' => []]);
             return $response;
         }
 
         $connection = $em->getRepository(Connection::class)->findOneBy(array('connectToken' => $connectToken));
-
         if($connection) {
             // Find Song
             $songToReview = $em->getRepository(Song::class)->findOneBy(array('id' => $songID));
@@ -99,27 +99,24 @@ public function addReview(Request $request, $songID)
             }
 
             $previousReview = $em->getRepository(SongReview::class)->findOneBy(array('song' => $songToReview, 'user' => $connection->getUser()));
-            
+
             if($previousReview) {
                 // Update Existing Review
-                $previousReview->setRecommended($reviewRecommend == "true" | $reviewRecommend == "1" ? true : false);
-                if($reviewComment != "") { $previousReview->setComment($reviewComment); }
+                $previousReview->setRecommended($reviewRecommend);
+                if($reviewComment !== "") { $previousReview->setComment($reviewComment); }
                 $previousReview->setReviewDate(new \DateTime('NOW'));
-
                 $em->persist($previousReview);
                 $em->flush();
-
                 $response = new JsonResponse(['version' => $this->getParameter('api_version'), 'status' => 200, 'data' => []]);
                 return $response;
             } else {
                 // Create new Review
                 $newReview = new SongReview();
                 $newReview->setUser($connection->getUser());
                 $newReview->setSong($songToReview);
-                $newReview->setRecommended($reviewRecommend == "true" || $reviewRecommend == "1" ? true : false);
+                $newReview->setRecommended($reviewRecommend);
                 $newReview->setComment($reviewComment);
                 $newReview->setReviewDate(new \DateTime('NOW'));
-
                 $em->persist($newReview);
                 $em->flush();
 

templates/apidocs/connect/reviews.html.twig

@@ -135,8 +135,8 @@
                                             <td>(string) connectToken</td>
                                         </tr>
                                         <tr>
-                                            <th>POST Form-Data</th>
-                                            <td>(int) recommend<br />
+                                            <th>JSON Body</th>
+                                            <td>(bool) recommend<br />
                                                 (string) comment</td>
                                         </tr>
                                     </table>