[BugFix] Fix the bug causing incomplete image files due to server forced shutdown. (backport #60398) (#60405)

Signed-off-by: gengjun-git <[email protected]>
Co-authored-by: gengjun-git <[email protected]>

Author: mergify[bot]

fe/fe-core/src/main/java/com/starrocks/leader/MetaHelper.java

@@ -54,6 +54,7 @@
 import java.io.OutputStream;
 import java.net.HttpURLConnection;
 import java.net.URL;
+import java.nio.charset.StandardCharsets;
 import java.nio.file.FileStore;
 import java.nio.file.Files;
 import java.nio.file.Path;
@@ -95,7 +96,7 @@ public static void downloadImageFile(String urlStr, int timeout, String version,
         String destFilename = Storage.IMAGE + "." + version;
         File partFile = new File(destDir, destFilename + MetaHelper.PART_SUFFIX);
         // 1. download to a tmp file image.xxx.part
-        try (OutputStream out = new FileOutputStream(partFile)) {
+        try (FileOutputStream out = new FileOutputStream(partFile)) {
             URL url = new URL(urlStr);
             conn = (HttpURLConnection) url.openConnection();
             conn.setConnectTimeout(timeout);
@@ -111,11 +112,13 @@ public static void downloadImageFile(String urlStr, int timeout, String version,
             BufferedInputStream bin = new BufferedInputStream(conn.getInputStream());
 
             // Do not limit speed in client side.
-            long bytes = IOUtils.copyBytes(bin, out, BUFFER_BYTES, CHECKPOINT_LIMIT_BYTES, true);
-
+            long bytes = IOUtils.copyBytes(bin, out, BUFFER_BYTES, CHECKPOINT_LIMIT_BYTES, false);
             if ((imageSize > 0) && (bytes != imageSize)) {
                 throw new IOException("Unexpected image size, expected: " + imageSize + ", actual: " + bytes);
             }
+
+            out.getChannel().force(true);
+
             checksum = conn.getHeaderField(X_IMAGE_CHECKSUM);
         } finally {
             if (conn != null) {
@@ -125,7 +128,11 @@ public static void downloadImageFile(String urlStr, int timeout, String version,
 
         // 2. write checksum if exists
         if (!Strings.isNullOrEmpty(checksum)) {
-            Files.writeString(Path.of(destDir.getAbsolutePath(), Storage.CHECKSUM + "." + version), checksum);
+            File checksumFile = Path.of(destDir.getAbsolutePath(), Storage.CHECKSUM + "." + version).toFile();
+            try (FileOutputStream fos = new FileOutputStream(checksumFile)) {
+                fos.write(checksum.getBytes(StandardCharsets.UTF_8));
+                fos.getChannel().force(true);
+            }
         }
 
         // 3. rename to image.xxx

fe/fe-core/src/main/java/com/starrocks/persist/ImageWriter.java

@@ -22,11 +22,12 @@
 import com.starrocks.persist.metablock.SRMetaBlockWriterV2;
 
 import java.io.DataOutputStream;
+import java.io.File;
+import java.io.FileOutputStream;
 import java.io.IOException;
 import java.io.OutputStream;
 import java.io.OutputStreamWriter;
 import java.nio.charset.StandardCharsets;
-import java.nio.file.Files;
 import java.nio.file.Path;
 import java.util.zip.CRC32;
 import java.util.zip.CheckedOutputStream;
@@ -68,9 +69,12 @@ public DataOutputStream getDataOutputStream() {
 
     public void saveChecksum() throws IOException {
         if (imageFormatVersion == ImageFormatVersion.v2) {
-            Path path = Path.of(imageDir, Storage.CHECKSUM + "." + imageJournalId);
+            File checksumFile = Path.of(imageDir, Storage.CHECKSUM + "." + imageJournalId).toFile();
             String checksum = String.valueOf(checkedOutputStream.getChecksum().getValue());
-            Files.writeString(path, checksum);
+            try (FileOutputStream fos = new FileOutputStream(checksumFile)) {
+                fos.write(checksum.getBytes(StandardCharsets.UTF_8));
+                fos.getChannel().force(true);
+            }
         }
     }
 }

fe/fe-core/src/main/java/com/starrocks/server/GlobalStateMgr.java

@@ -243,9 +243,9 @@
 import java.io.DataOutputStream;
 import java.io.EOFException;
 import java.io.File;
+import java.io.FileOutputStream;
 import java.io.IOException;
 import java.io.InputStream;
-import java.io.OutputStream;
 import java.nio.file.Files;
 import java.util.ArrayList;
 import java.util.HashSet;
@@ -1717,7 +1717,7 @@ public void saveImage(ImageWriter imageWriter, File curFile) throws IOException
         LOG.info("start save image to {}. is ckpt: {}", curFile.getAbsolutePath(), GlobalStateMgr.isCheckpointThread());
 
         long saveImageStartTime = System.currentTimeMillis();
-        try (OutputStream outputStream = Files.newOutputStream(curFile.toPath())) {
+        try (FileOutputStream outputStream = new FileOutputStream(curFile)) {
             imageWriter.setOutputStream(outputStream);
             try {
                 saveHeader(imageWriter.getDataOutputStream());
@@ -1758,6 +1758,9 @@ public void saveImage(ImageWriter imageWriter, File curFile) throws IOException
                 throw new IOException("Save meta block failed ", e);
             }
 
+            imageWriter.getDataOutputStream().flush();
+            outputStream.getChannel().force(true);
+
             imageWriter.saveChecksum();
 
             long saveImageEndTime = System.currentTimeMillis();

fe/fe-core/src/main/java/com/starrocks/staros/StarMgrServer.java

@@ -236,8 +236,11 @@ public boolean replayAndGenerateImage(String imageDir, long checkPointVersion) t
                 LOG.warn("middle star mgr image {} already existed.", ckpt.getAbsolutePath());
             }
         }
-        try (DataOutputStream out = new DataOutputStream(new FileOutputStream(ckpt))) {
-            getStarMgr().dumpMeta(out);
+        try (FileOutputStream fos = new FileOutputStream(ckpt);
+                DataOutputStream dos = new DataOutputStream(fos)) {
+            getStarMgr().dumpMeta(dos);
+            dos.flush();
+            fos.getChannel().force(true);
         }
         // Move image.ckpt to image.dataVersion
         LOG.info("move star mgr " + ckpt.getAbsolutePath() + " to " + imageFile.getAbsolutePath());